Make the 'Enqueue all' button for Pending jobs optional #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chrismear Sorry this has been neglected so long. This seems like a reasonable change. You provided a good explanation of your use case, the code changes and a supporting test, and documentation. Do you think this is still safe to merge (in terms of potential regressions) and include as part of the next gem release? |
|
@andyatkinson Yes, I think this is still safe to merge. Shouldn't change any existing behaviour. Let me know if there's anything I can do to help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a setting,
allow_requeue_pending, which, when set tofalse, removes the 'Enqueue all immediately' feature from the Pending jobs page.If you're using the
run_atattribute of Delayed::Jobs to intentionally set jobs to run at a particular time in the future, it's quite risky to have a button that schedules them all to run immediately. Being able to disable the button is a useful safety feature for apps that are using Delayed Job in this way.