Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix run at "relatize_date" inaccuracy #82

Merged
merged 1 commit into from
Apr 21, 2017

Conversation

litenup
Copy link
Contributor

@litenup litenup commented Oct 12, 2015

Addresses issue #69
The run at time in word is not accurate, this fixes the minor logic issue in relatize_date script.

@andyatkinson
Copy link
Collaborator

@litenup Sorry this languished for so long. Did you consider "fixing" this by pulling in the same/a similar relatize date script from an external source? (Where presumably a similar fix was already made). This struck me as something that could be externalized. On the other hand, if this file was already in here, we could move forward with your change. Did you conduct some manual testing on it? JS unit tests for this type of file would be nice, but in lieu of that, if you feel good this isn't going to break things, we should merge it.

@litenup
Copy link
Contributor Author

litenup commented Apr 1, 2017

@andyatkinson no worries
I checked external sources and there's no future date support, the future date support was implemented by @ferlatte earlier and might be unique to this project.

I conducted manual test and it doesn't break anything. Feel good it can be merged.

@andyatkinson
Copy link
Collaborator

@litenup Thanks for the feedback. I'll merge it this week. We can also cut a new gem release. I'll ping you when that happens. Would appreciate additional help testing the new gem version as I'm not using this anymore myself.

@andyatkinson andyatkinson merged commit 50ffcc3 into ejschmitt:master Apr 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants