Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a section for Heroku worker monitoring and zombie detection #92

Closed
wants to merge 6 commits into from

Conversation

hammady
Copy link

@hammady hammady commented Nov 29, 2016

Adding a section to monitor heroku dynos in a table view.
Also sometimes when a heroku dyno dies and leaves the job locked, this PR will list those zombie jobs so that they can be requeued or cleared.
For the heroku integration to work, 2 environment variables need to be set:
DJWEB_HEROKU_TOKEN and DJWEB_HEROKU_APP_NAME
If any of these 2 are not found, the gem will work normally without heroku integration.

…ocked by already gone dynos. For this to work you need to gem 'platform-api' in Gemfile and set 2 environment variables: DJWEB_HEROKU_TOKEN and DJWEB_HEROKU_APP_NAME.
…DYNO'] and overriding the worker.name (locked_by) to embed the dyno id, so that matching on dyno_id works
@andyatkinson
Copy link
Collaborator

@hammady Interesting. I'm not familiar with this. Since a lot of time has passed, is this something that's still beneficial and works on Heroku (and does Heroku work in the same way as when this was written?). If you could re-test, can you also comment on whether this change might break outside of a Heroku environment. Finally, could you add some documentation about the environment variables, and a one-liner of detail about what the problem is, and how this solves it (you mostly covered it in the PR message, but it would be nice to have as Readme documentation for this project as well). Thanks.

@andyatkinson
Copy link
Collaborator

@hammady Is this still a thing you want to do? If not, I would close this PR. If I don't hear back from you, I'll assume this isn't something you'd like to pursue releasing (and supporting if there are issues). Thanks.

@hammady
Copy link
Author

hammady commented Feb 22, 2018

I was relying on this PR in production until last December and it was working on heroku. I believe it should still work. I will try to find some time soon to fulfill your request before merging.

@andyatkinson
Copy link
Collaborator

@hammady Oh ok. That seems fine then. Could you add a section to the Readme on your PR about what this does, and maybe the versions of Rails it was running in, and maybe some notes about the Heroku stack you're using? That way if someone wants to use it or has trouble with it, they have a better starting point to know how it was being used before.

@hammady hammady closed this Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants