We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The problem is this if block in get_node_src_url:
if version > "0.5.0": node_url = 'http://nodejs.org/dist/v%s/%s' % (version, tar_name) else: node_url = 'http://nodejs.org/dist/%s' % (tar_name)
The above evaluates to False for 0.10.0. A better option might be to use parse_version from pkg_resources (distutils) and change this to
if parse_version(version) > parse_version("0.5.0"): node_url = 'http://nodejs.org/dist/v%s/%s' % (version, tar_name) else: node_url = 'http://nodejs.org/dist/%s' % (tar_name)
as per this stackoverflow answer: http://stackoverflow.com/a/6972866
The text was updated successfully, but these errors were encountered:
Merge pull request #29 from bhang/master
179d153
Fix for #28 - use pkg_resources.parse_version to compare versions
Successfully merging a pull request may close this issue.
The problem is this if block in get_node_src_url:
The above evaluates to False for 0.10.0. A better option might be to use parse_version from pkg_resources (distutils) and change this to
as per this stackoverflow answer: http://stackoverflow.com/a/6972866
The text was updated successfully, but these errors were encountered: