Skip to content

Commit

Permalink
Issue-430 - Skip install-deps job for now
Browse files Browse the repository at this point in the history
  • Loading branch information
huntharo committed May 22, 2024
1 parent 0e18b07 commit c6c0700
Showing 1 changed file with 15 additions and 13 deletions.
28 changes: 15 additions & 13 deletions .github/workflows/nodejs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,21 +3,23 @@ name: Node CI
on: [push, pull_request]

jobs:
install-deps:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [12.x, 14.x, 16.x]
steps:
- uses: actions/checkout@v4
- uses: ./.github/actions/configure-nodejs
with:
node-version: ${{ matrix.node-version }}
lookup-only: 'true' # We only want to lookup from the cache - if a hit, this job does nothing
# We do not strictly need an install-deps job
# because we do not kick of multiple jobs in parallel
# that would all try to install deps when the key changes.
# Skipping this saves a few seconds until the point where we need it.
# install-deps:
# runs-on: ubuntu-latest
# strategy:
# matrix:
# node-version: [12.x, 14.x, 16.x]
# steps:
# - uses: actions/checkout@v4
# - uses: ./.github/actions/configure-nodejs
# with:
# node-version: ${{ matrix.node-version }}
# lookup-only: 'true' # We only want to lookup from the cache - if a hit, this job does nothing

build:
needs:
- install-deps
runs-on: ubuntu-latest
strategy:
matrix:
Expand Down

0 comments on commit c6c0700

Please sign in to comment.