Skip to content

Commit

Permalink
Deprecate otc_coalescing_strategy, otc_coalescing_window_us, otc_coal…
Browse files Browse the repository at this point in the history
…escing_enough_coalesced_messages,

otc_backlog_expiration_interval_ms (CASSANDRA-17377)
  • Loading branch information
ekaterinadimitrova2 committed Feb 12, 2022
1 parent c60ad61 commit a0f6b89
Show file tree
Hide file tree
Showing 3 changed files with 28 additions and 0 deletions.
2 changes: 2 additions & 0 deletions CHANGES.txt
@@ -1,4 +1,6 @@
4.0.3
* Deprecate otc_coalescing_strategy, otc_coalescing_window_us, otc_coalescing_enough_coalesced_messages,
otc_backlog_expiration_interval_ms (CASSANDRA-17377)
* Improve start up processing of Incremental Repair information read from system.repairs (CASSANDRA-17342)

4.0.2
Expand Down
12 changes: 12 additions & 0 deletions NEWS.txt
Expand Up @@ -33,6 +33,18 @@ restore snapshots created with the previous major version using the
'sstableloader' tool. You can upgrade the file format of your snapshots
using the provided 'sstableupgrade' tool.

4.0.3
=====

New features
------------


Upgrading
---------
- otc_coalescing_strategy, otc_coalescing_window_us, otc_coalescing_enough_coalesced_messages,
otc_backlog_expiration_interval_ms are deprecated and will be removed at earliest with next major release to
prevent the breaking change that happened in 4.0.2 after CASSANDRA-17132.

This comment has been minimized.

Copy link
@driftx

driftx Feb 12, 2022

we can stop after 'with next major release'

This comment has been minimized.

Copy link
@driftx

driftx Feb 12, 2022

and could also mention that it has been a no-op since 3.11

This comment has been minimized.

Copy link
@ekaterinadimitrova2

ekaterinadimitrova2 Feb 12, 2022

Author Owner

New commit added to address that c115d35


4.0.2
=====
Expand Down
14 changes: 14 additions & 0 deletions src/java/org/apache/cassandra/config/Config.java
Expand Up @@ -369,6 +369,20 @@ public class Config
*/
public volatile ConsistencyLevel ideal_consistency_level = null;

@Deprecated
public String otc_coalescing_strategy = "DISABLED";

@Deprecated
public static final int otc_coalescing_window_us_default = 200;
@Deprecated
public int otc_coalescing_window_us = otc_coalescing_window_us_default;
@Deprecated
public int otc_coalescing_enough_coalesced_messages = 8;
@Deprecated
public static final int otc_backlog_expiration_interval_ms_default = 200;
@Deprecated
public volatile int otc_backlog_expiration_interval_ms = otc_backlog_expiration_interval_ms_default;

public int windows_timer_interval = 0;

/**
Expand Down

0 comments on commit a0f6b89

Please sign in to comment.