Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix validator for proteins. remove unused parameters in validate. #1

Merged
merged 3 commits into from
May 1, 2018

Conversation

bradfordcondon
Copy link

remove qrange. switch _set_protein_gap to _set_gap for retrieving gap open/extend values.

@bradfordcondon
Copy link
Author

sorry usually i write more in my PRs. This PR resolves issues with tripal#33
namely form submission for all blasts won't go through because protein-based ones dont properly retrieve the gap cost/extend values and the nucleotide submission won't go through because of the qrange key.

@ekcannon
Copy link
Owner

ekcannon commented May 1, 2018

Thanks for catching that @bradfordcondon! When I made the pull request to Tripal I had a vague sense I'd missed something. The code is looking better and better.

RE: qrange and culling limit: I'm inclined to remove all mention of both and make an issue on Tripal/tripal_blast to examine them more closely, and if possible, add them to advanced options.

@ekcannon ekcannon merged commit 9663910 into ekcannon:advancedoptions May 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants