Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change visibility of properties #3

Closed
PeeHaa opened this issue Jan 3, 2017 · 4 comments
Closed

Change visibility of properties #3

PeeHaa opened this issue Jan 3, 2017 · 4 comments

Comments

@PeeHaa
Copy link
Collaborator

PeeHaa commented Jan 3, 2017

These can be made private / protected: https://github.com/ekinhbayar/gitamp/blob/master/src/Events/GithubEvent.php#L21-L29
@ekinhbayar
Copy link
Owner

That means we should not json_encode the array of objects then. IIRC if they were not public encoded values of property names are different.

@PeeHaa
Copy link
Collaborator Author

PeeHaa commented Jan 3, 2017

Oh I missed it we are doing that. Let me look.

@PeeHaa
Copy link
Collaborator Author

PeeHaa commented Jan 3, 2017

Yes. Good point. Need to give this one some more thought.

@PeeHaa
Copy link
Collaborator Author

PeeHaa commented Jan 4, 2017

Ohhh apparently that monster push I just did also solved this... \o/

That's an side effect I like.

@PeeHaa PeeHaa closed this as completed Jan 4, 2017
This was referenced Feb 10, 2017
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@PeeHaa @ekinhbayar