Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly handle connection errors #30

Closed
PeeHaa opened this issue Jan 15, 2017 · 2 comments
Closed

Properly handle connection errors #30

PeeHaa opened this issue Jan 15, 2017 · 2 comments
Milestone
v1

Comments

@PeeHaa
Copy link
Collaborator

PeeHaa commented Jan 15, 2017

Don't let the connection error exception bubble all the way but instead just return an empty Result object.

This may be hard to debug / find out when / why this happens so we probably want to introduce logging.
@PeeHaa PeeHaa added this to the v1 milestone Jan 15, 2017
@PeeHaa PeeHaa mentioned this issue Jan 15, 2017
Closed
@PeeHaa
Copy link
Collaborator Author

PeeHaa commented Jan 29, 2017

Even after properly handling connection errors once dnslib is fucked it's FUBAR.

See #26

@PeeHaa
Copy link
Collaborator Author

PeeHaa commented Jan 29, 2017

Closed by a4de8a1

@PeeHaa PeeHaa closed this as completed Jan 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1
Development

No branches or pull requests
1 participant
@PeeHaa