Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added openwall dependency repository #54

Merged
merged 1 commit into from Nov 24, 2014
Merged

Added openwall dependency repository #54

merged 1 commit into from Nov 24, 2014

Conversation

xavismeh
Copy link
Contributor

Fix #53

@GromNaN
Copy link
Contributor

GromNaN commented Nov 24, 2014

Is it really a mandatory dependency ?
It would be more user friendly if this was only a soft dependency (moved to "require-dev").
was only a soft dependency (moved to "require-dev").

@xavismeh
Copy link
Contributor Author

That's actually more complicated. This lib is mandatory since it's used within the wp_post_password_required twig function (port from post_password_required orginal wordpress' function). You can see it here : https://github.com/ekino/EkinoWordpressBundle/blob/master/Manager/PostManager.php#L52

@GromNaN
Copy link
Contributor

GromNaN commented Nov 24, 2014

isn't it required only if I want to use this Twig function ?

@xavismeh
Copy link
Contributor Author

Actually no, the twig function is just a wrapper to the PostManager

@eko
Copy link
Collaborator

eko commented Nov 24, 2014

Thank you for this fix @xavismeh :)

eko added a commit that referenced this pull request Nov 24, 2014
Added openwall dependency repository
@eko eko merged commit a69233c into ekino:master Nov 24, 2014
@eko
Copy link
Collaborator

eko commented Nov 24, 2014

I think we could talk about moving this library in the suggest section of the composer.json and add a check for the class to exist into the code later if you want.

@xavismeh
Copy link
Contributor Author

You're welcome @eko :)
I agree that putting this into the "suggest" section makes sense. I wanted to do this at first but it involves to think about a way to remove this dependency if the twig helpers are not enabled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unable to install 'php composer.phar update ekino/wordpress-bundle'
3 participants