Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: next release #8

Merged
merged 1 commit into from Jan 23, 2019
Merged

Feature: next release #8

merged 1 commit into from Jan 23, 2019

Conversation

bnadim
Copy link
Contributor

@bnadim bnadim commented Nov 19, 2018 •
edited

Changed:

  • Update all dependencies
  • Remove NODE_ENV support and move to CONF_DIR and CONF_FILES
  • Support .yml and .yaml files with priority to .yaml files
  • Support spaces in env var (ie: CONF_FILES="file_a, file_b"
  • Throw an error (and crash) if a conf file defined in CONF_FILES can not be found

@bnadim bnadim force-pushed the feature/next-release branch 2 times, most recently from 62db23d to a2c9148 Compare November 19, 2018 18:43
@bnadim bnadim requested a review from plouc November 19, 2018 18:44
@coveralls
Copy link

coveralls commented Nov 19, 2018 •
edited

Coverage Status

Coverage increased (+0.09%) to 99.057% when pulling 06d68a7 on feature/next-release into 0cbc087 on master.

@bnadim bnadim self-assigned this Nov 19, 2018
@bnadim bnadim added this to the 0.4.0 milestone Nov 19, 2018
@bnadim bnadim force-pushed the feature/next-release branch 4 times, most recently from f94306b to 1540081 Compare November 20, 2018 17:27
plouc
plouc reviewed Nov 27, 2018
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
index.js Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
@bnadim
Copy link
Contributor Author

bnadim commented Jan 14, 2019

@plouc is it ok now to merge please ?

@bnadim
Copy link
Contributor Author

bnadim commented Jan 22, 2019

@plouc please can you confirm ?

@plouc
Copy link
Contributor

plouc commented Jan 22, 2019

@bnadim LGTM

@bnadim bnadim merged commit a7dfbc8 into master Jan 23, 2019
@bnadim bnadim deleted the feature/next-release branch January 23, 2019 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plouc plouc plouc left review comments

Assignees

@bnadim bnadim

Labels
enhancement
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bnadim @coveralls @plouc