-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add slackUsernameFormat config option #171
Conversation
1 similar comment
@ekmartin: lol did you add Coveralls twice or something |
Brilliant! I agree with what you said in #56 (comment) - let's go with Should this maybe be nested under an object, to make it cleaner to add support for IRC username formatting as well? "usernameFormat": {
"slack": "$username (IRC)",
"irc": "<$username>"
} Or do you think it's clearer with just EDIT: No idea what's happening with coveralls, let's see if it's a one-time incident |
Great! Will do. I don't think it should be nested, but I also see no use for |
I think one use case would be if people for some reason would want to remove the username when messages are posted to IRC. Might be good to have both just for unity, but we can merge this and look at it later. |
@ekmartin: eh yeah let's just deal with that later. Updated default Slack username format. |
Great, thanks! I'll create a release later. |
Released in 3.9.0 - thanks again! |
Close #56