Add Comonad instances for Tagged s with s of any kind
#43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanGlScott
reviewed
Feb 26, 2018
src/Control/Comonad.hs
Outdated
| @@ -3,6 +3,9 @@ | |||
| {-# LANGUAGE DeriveDataTypeable, StandaloneDeriving, Safe, DefaultSignatures #-} | |||
| #elif __GLASGOW_HASKELL__ >= 702 | |||
| {-# LANGUAGE Trustworthy, DefaultSignatures #-} | |||
| #endif | |||
| #if __GLASGOW_HASKELL__ >= 706 | |||
| {-# LANGUAGE KindSignatures, PolyKinds #-} | |||
There was a problem hiding this comment.
No need to enable KindSignatures—that's implied by PolyKinds.
Before the change, `s` had to be of kind `*`. The new instances are obtained by enabling the `PolyKinds` language extension in the `Control.Comonad` module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the change,
shad to be of kind*.The new instances are obtained by enabling the
PolyKindsextension in theControl.Comonadmodule.