Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move indexed-traversable instance #54

Merged
merged 1 commit into from Dec 15, 2020
Merged

Move indexed-traversable instance #54

merged 1 commit into from Dec 15, 2020

Conversation

phadej
Copy link
Contributor

@phadej phadej commented Dec 13, 2020

No description provided.

phadej added a commit to haskellari/indexed-traversable that referenced this pull request Dec 13, 2020
@phadej
Drop comonad dependency
f7c7796 
The TracedT instance will be in `comonad` itself.
ekmett/comonad#54
This was referenced Dec 13, 2020
Merged
Merged
arybczak
arybczak reviewed Dec 13, 2020
View reviewed changes
comonad.cabal
@@ -68,6 +68,17 @@ flag distributive
default: True
manual: True

flag indexed-traversable
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this flag make sense considering that indexed-traversable has only GHC deps?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto distributive and tagged on recent enough GHCs. IMHO yes, for consistency. The implementation of this flag is quite cheap.

@cartazio
Copy link
Collaborator

Might it be worth just moving ci to GitHub actions? I’ll have a standardized template in a few days

@phadej
Copy link
Contributor Author

phadej commented Dec 13, 2020

@RyanGlScott if this is fine, then I'll go forward with making indexed-traversable releases, and amending comonad and free PR to not use http-tarballs.

RyanGlScott
RyanGlScott reviewed Dec 13, 2020
View reviewed changes
comonad.cabal Outdated Show resolved Hide resolved
CHANGELOG.markdown Outdated Show resolved Hide resolved
@RyanGlScott
Copy link
Collaborator

if this is fine, then I'll go forward with making indexed-traversable releases, and amending comonad and free PR to not use http-tarballs.

Sounds good to me. Thanks, @phadej!

@phadej
Copy link
Contributor Author

phadej commented Dec 15, 2020

This build turned green.

@RyanGlScott RyanGlScott merged commit f31b61c into ekmett:master Dec 15, 2020
@RyanGlScott
Copy link
Collaborator

Thanks! I've uploaded comonad-5.0.7 to Hackage with these changes.

@phadej phadej deleted the indexed-traversable branch December 16, 2020 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arybczak arybczak arybczak left review comments

@RyanGlScott RyanGlScott RyanGlScott left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@phadej @cartazio @RyanGlScott @arybczak