New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change the type of generalBracket, fixes #63 #64
Commits on Mar 6, 2018
-
'MSpec' was an existential in 'm', but I want to construct another type which has both an 'MSpec' and some other 'm'-related fields. So I am exposing the 'm' in 'MSpec' and creating another existential which abstracts over it.
Configuration menu - View commit details
-
Copy full SHA for ca70699 - Browse repository at this point
Copy the full SHA ca70699View commit details -
Configuration menu - View commit details
-
Copy full SHA for 04a5988 - Browse repository at this point
Copy the full SHA 04a5988View commit details -
a series of tests about detectable effects
To make sure that the all the effects performed while releasing a resource are preserved, not just the IO effects. I'm writing the tests first, so the tests currently fail.
Configuration menu - View commit details
-
Copy full SHA for dd90823 - Browse repository at this point
Copy the full SHA dd90823View commit details -
test that the release error wins
It is easy to accidentally implement the 'ExceptT' instance in a way which causes the error message thrown during 'use' to get propagated instead of the one thrown by 'release'. When both 'use' and 'release' throw an IO exception, the one thrown by 'release' wins, so I think we should follow suit.
Configuration menu - View commit details
-
Copy full SHA for e175f61 - Browse repository at this point
Copy the full SHA e175f61View commit details
Commits on Mar 7, 2018
-
move the CatchT warning to the instance documentation
Now that we have documentation for individual instances, there is no need to repeat this seldom-used information here.
Configuration menu - View commit details
-
Copy full SHA for 7e9b7df - Browse repository at this point
Copy the full SHA 7e9b7dfView commit details -
explain the difference with lifted-base
The exceptions package used to have an undocumented advantage over lifted-base, namely that the non-IO effects are not discarded, but then exceptions-0.9.0 made a breaking change which lost this advantage. In this PR, I am restoring this advantage, and I am documenting it, both to help users decide which package to pick, and so we don't foolishly repeat that mistake.
Configuration menu - View commit details
-
Copy full SHA for 20833ab - Browse repository at this point
Copy the full SHA 20833abView commit details -
change the type of generalBracket, fixes #63
This is the PR's main change. I make the type of 'generalBracket' even more general, which allows me to fix the implementations of 'StateT' and 'WriterT' so they don't discard their state changes.
Configuration menu - View commit details
-
Copy full SHA for 9e42dd8 - Browse repository at this point
Copy the full SHA 9e42dd8View commit details -
if ExceptT has one, MaybeT should have one too
Configuration menu - View commit details
-
Copy full SHA for 6f51794 - Browse repository at this point
Copy the full SHA 6f51794View commit details -
Update the documentation to reflect the difference between an exception and an error, calling out the cases in which the user might expect to catch all errors but will only catch all exceptions. In particular, 'onException' will only run the handler when an exception is thrown but not when any other kind of error is thrown; this is not particularly useful, but we can't do better without changing its type signature. A new function 'onError' is introduced which does not have this flaw.
Configuration menu - View commit details
-
Copy full SHA for b64993d - Browse repository at this point
Copy the full SHA b64993dView commit details -
to match the style of the existing codebase
Configuration menu - View commit details
-
Copy full SHA for 1cacf63 - Browse repository at this point
Copy the full SHA 1cacf63View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5c725b7 - Browse repository at this point
Copy the full SHA 5c725b7View commit details
Commits on Mar 8, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 82659ea - Browse repository at this point
Copy the full SHA 82659eaView commit details -
Configuration menu - View commit details
-
Copy full SHA for bd6a570 - Browse repository at this point
Copy the full SHA bd6a570View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4352de7 - Browse repository at this point
Copy the full SHA 4352de7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3a7e35b - Browse repository at this point
Copy the full SHA 3a7e35bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2aa7dae - Browse repository at this point
Copy the full SHA 2aa7daeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9d4ee1b - Browse repository at this point
Copy the full SHA 9d4ee1bView commit details -
Configuration menu - View commit details
-
Copy full SHA for cd317d8 - Browse repository at this point
Copy the full SHA cd317d8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 562b331 - Browse repository at this point
Copy the full SHA 562b331View commit details -
Configuration menu - View commit details
-
Copy full SHA for 594477e - Browse repository at this point
Copy the full SHA 594477eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9e168e8 - Browse repository at this point
Copy the full SHA 9e168e8View commit details -
@SInCE annotations for MaybeT and ExceptT
the Either instance has one, so MaybeT and ExceptT should have one as well
Configuration menu - View commit details
-
Copy full SHA for c1a5014 - Browse repository at this point
Copy the full SHA c1a5014View commit details -
Configuration menu - View commit details
-
Copy full SHA for eb13cec - Browse repository at this point
Copy the full SHA eb13cecView commit details -
rename the type variables in bracket*
to match the order in which the actions will be executed, like in generalBracket.
Configuration menu - View commit details
-
Copy full SHA for 1bae026 - Browse repository at this point
Copy the full SHA 1bae026View commit details
Commits on Mar 9, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 7d74727 - Browse repository at this point
Copy the full SHA 7d74727View commit details -
Configuration menu - View commit details
-
Copy full SHA for dc3e243 - Browse repository at this point
Copy the full SHA dc3e243View commit details -
Configuration menu - View commit details
-
Copy full SHA for 91fe5e5 - Browse repository at this point
Copy the full SHA 91fe5e5View commit details