Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MonadPlus.Free does not satisfy the associative law #38

Closed
xuwei-k opened this issue Jan 29, 2014 · 3 comments
Closed

MonadPlus.Free does not satisfy the associative law #38

xuwei-k opened this issue Jan 29, 2014 · 3 comments
Milestone
4.6

Comments

@xuwei-k
Copy link

xuwei-k commented Jan 29, 2014

No description provided.

xuwei-k added a commit to xuwei-k/scalaz that referenced this issue Jan 29, 2014
@xuwei-k
wip Free MonadPlus. add FreePlus.Gosub
b42d789 
ekmett/free#38
https://github.com/ekmett/free/blob/v4.2/src/Control/MonadPlus/Free.hs#L146-L149
https://github.com/ekmett/free/blob/v4.2/src/Control/MonadPlus/Free.hs#L69-L73
@ekmett
Copy link
Owner

ekmett commented Mar 11, 2014

Happy to take a fix. I don't use it.

@ekmett
Copy link
Owner

ekmett commented Mar 16, 2014

I suppose the right fix is to switch to to be FreeT f []. That gives us a legal MonadPlus, and the initiality of the solution comes from [] as a free monoid.

@ekmett
Copy link
Owner

ekmett commented Mar 16, 2014

Resolved. 69e35ad removes Control.MonadPlus.Free in favor of FreeT f []

We still need to do something similar for Control.Alternative.Free.

@ekmett ekmett closed this as completed Mar 16, 2014
@ekmett ekmett added this to the 4.6 milestone Mar 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.6
Development

No branches or pull requests
2 participants
@ekmett @xuwei-k