Skip to content

Commit

Permalink
Strengthen language
Browse files Browse the repository at this point in the history 
ekmett's word is law around these parts :P
  • Loading branch information
@Gurkenglas
Gurkenglas committed Aug 11, 2018
1 parent 48ac035 commit 5c0ed6d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/Control/Lens/Unsound.hs
View file
Expand Up @@ -95,7 +95,7 @@ prismSum k =

-- | A generalization of `mappend`ing folds: A union of disjoint traversals.
--
-- Traversing the same entry twice is discouraged.
-- Traversing the same entry twice is illegal.

This comment has been minimized.

Sign in to view

Copy link
@neongreen

neongreen Aug 11, 2018

Contributor

It'd be nicer to say why it is illegal and what are the consequences (otherwise there will be people scared of doing it even though for their usecase it's fine, and there will also be people who will ignore the admonition unless it's accompanied by a sound argument)
--
-- Are you looking for 'Control.Lens.Traversal.failing'?
--
Expand Down

0 comments on commit 5c0ed6d

Please sign in to comment.