-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doctests new build #701
Doctests new build #701
Conversation
Can you add a preamble to the Setup.lhs like:
This way when run on older cabal versions it'll be more robust. |
a4b0425
to
2d52a73
Compare
@ekmett, I did. Let's see what travis says. I guess Tested locally: can run |
0aa054d
to
d66fd5e
Compare
d66fd5e
to
f6b1d52
Compare
Thanks for doing this, @phadej! Since there's a number of other packages that use a similar
|
@RyanGlScott For 2: The lens diagram copying code is something none of other packages need: https://github.com/ekmett/lens/blob/master/Setup.lhs#L42-L44 For 1: I'm not sure, it might work with But anyhow, |
|
@phadej does this work with older cabal-install versions? I'd assume it requires a cabal-install that knows about |
parsing doesn't fail, cabal just says "unknown section". You can see it e.g. from https://travis-ci.org/ekmett/distributive/builds/197339532 |
Oh cool, I had assumed that this was less backwards-compatible than it actually is. This is nice, thanks! |
No description provided.