Bump version number to 5 #955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The next `lens` release will migrate to using the
`{Functor,Foldable,Traversable}WithIndex` classes from the
`indexed-traversable` package. As discussed in
#951 (comment), this poses a
challenge for downstream code that use instances of
`{Functor,Foldable,Traversable}WithIndex` from `indexed-traversable` while
also indirectly importing `lens`. This is because the code can succeed or fail
to compile depending on what version of `lens` is picked in the build plan,
even if there isn't a direct dependency declared against `lens`!
The best way to mitigate this possibility is to ensure that packages that
depend on `lens` and define `{Functor,Foldable,Traversable}WithIndex` have
appropriately tight version bounds on `lens`. At the time of writing, the most
recent Hackage release is `lens-4.19.*`, so we could ensure that packages
either declare `< 4.20` or `< 5`. As it turns out, many packages in the
Kmettiverse already declare `< 5`, so in order to avoid making more Hackage
revisions than we absolutely need to, we have decided to just bump the version
number to 5. In other words, we are bumping the "Kmett-major" version number.
It's probably a good time to do this regardless, as there are enough breaking
changes in the next release that it makes sense marketing-wise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The next
lensrelease will migrate to using the{Functor,Foldable,Traversable}WithIndexclasses from theindexed-traversablepackage. As discussed in #951 (comment), this poses a challenge for downstream code that use instances of{Functor,Foldable,Traversable}WithIndexfromindexed-traversablewhile also indirectly importinglens. This is because the code can succeed or fail to compile depending on what version oflensis picked in the build plan, even if there isn't a direct dependency declared againstlens!The best way to mitigate this possibility is to ensure that packages that depend on
lensand define{Functor,Foldable,Traversable}WithIndexhave appropriately tight version bounds onlens. At the time of writing, the most recent Hackage release islens-4.19.*, so we could ensure that packages either declare< 4.20or< 5. As it turns out, many packages in the Kmettiverse already declare< 5, so in order to avoid making more Hackage revisions than we absolutely need to, we have decided to just bump the version number to 5. In other words, we are bumping the "Kmett-major" version number. It's probably a good time to do this regardless, as there are enough breaking changes in the next release that it makes sense marketing-wise.