-
Notifications
You must be signed in to change notification settings - Fork 46
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Machines get stuck and don't stop #40
Comments
The version of It should have had the same semantics as |
So I think the The other is the change to fanout. For that I'm going to either defer to @acowley about the semantics of that operation (as he wrote it) or take it upon myself when I have more time and a clearer head. |
It seems I misunderstood the Haddock comment for
But it doesn't start it up again:
|
Ah. I see the description difference. The word "stop" there came from before we added the
should run as intended. It really is intended to run until the plan |
OK, thanks, I understand now. I pushed some more commits. I avoided rewriting the git history because that might have been confusing. |
The fanout change probably makes sense; I've not focused enough on machines that stop. It would be good to write some tests (doctests maybe) to demonstrate stopping behavior as it is a bit murky in most places. Or perhaps we need to do a documentation audit to standardize terminology so we can concisely say what happens when we, say, fanout before upstream stops, but downstream processes don't all stop at the same time. |
@acowley: Makes sense. Volunteering? ;) |
I just saw this ticket and thought I'd mention that #70 should fix the |
With both |
This is an informal pull request, because I've created my commits against v0.4.1 in a new 0.4.1 branch which doesn't exist in your repo, so I can't create a proper pull request.
Please see https://github.com/greenrd/machines/tree/0.4.1
I have two commits there, one fixing a bug relating to
repeatedly
, and the other relating tofanout
- both bugs cause machines to not stop when they should. Well, I'm sure thefanout
one is a bug, anyway; I haven't actually verified that therepeatedly
change fixes a bug, but it makes sense to me.The text was updated successfully, but these errors were encountered: