Use new, safer GHC.TypeLits API to define reify{Nat,Symbol}
#53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With `base-4.18` (GHC 9.6), we can now define `reifyNat` and `reifySymbol` without any uses of `unsafeCoerce`. Hooray! What's more, this does not exhibit the incoherence issues seen when trying to use `withDict` to define `reify` or `give`. See this comment for an explanation of why this is the case: haskell/core-libraries-committee#85 (comment) This addresses one part of #44. It does not fix it completely, as it does not address `reify` and `give`, which are separate matters.
RyanGlScott
force-pushed
the
T44-reifyNat-reifySymbol
branch
from
c1072fb
to
111e36e
Compare
|
I hope that the silly build plan that the GHC 9.6 CI job picks will be resolved by haskell/aeson#1005. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
base-4.18(GHC 9.6), we can now definereifyNatandreifySymbolwithout any uses ofunsafeCoerce. Hooray! What's more, this does not exhibit the incoherence issues seen when trying to usewithDictto definereifyorgive. See this comment for an explanation of why this is the case: haskell/core-libraries-committee#85 (comment)This addresses one part of #44. It does not fix it completely, as it does not address
reifyandgive, which are separate matters.