Skip to content

Commit

Permalink
Backport fixity declaration for Data.List.NonEmpty.git status
Browse files Browse the repository at this point in the history
  • Loading branch information
RyanGlScott committed Jun 23, 2017
1 parent d2639cb commit 6ccef33
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src-ghc7/Data/List/NonEmpty.hs
Expand Up @@ -629,6 +629,7 @@ isPrefixOf (y:ys) (x :| xs) = (y == x) && List.isPrefixOf ys xs
| n > 0 = xs List.!! (n - 1)
| otherwise = error "NonEmpty.!! negative argument"
{-# INLINE (!!) #-}
infixl 9 !!

-- | The 'zip' function takes two streams and returns a stream of
-- corresponding pairs.
Expand Down

4 comments on commit 6ccef33

@RyanGlScott
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, that commit message should contain Data.List.NonEmpty.!!, not Data.List.NonEmpty.git. bash took over when I git committed that.

@hvr
Copy link
Collaborator

@hvr hvr commented on 6ccef33 Jun 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RyanGlScott ....so I guess we need a major ver bump, i,e, semigroups-0.19...

@RyanGlScott
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really. The default fixity for infix functions is infixl 9 anyways, so this commit doesn't actually change any behavior (it just makes it explicit).

@hvr
Copy link
Collaborator

@hvr hvr commented on 6ccef33 Jun 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right...! [insert minor generic rant about commit messages not including motivation to help reader establish context] :-)

Please sign in to comment.