Allow hashable-1.2.5 and thus GHC-7.0 #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phadej
changed the title
This is compomise: we still support GHC-7.0, but `Hashable Arg` instance depends on `hashable` version. I think this is morally ok, as *observing* difference would require downstream to depend on `hashable`, thus they can differentiate. But that's however not entirely true, if one e.g. uses `Arg` as a key in `HashMap`, yet one wouldn't with old `hashable` as then `Hashable Arg` and `Eq Arg` disagree, so it probably doesn't work anyway.
|
Since |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and this another:
This is compomise: we still support GHC-7.0, but
Hashable Arginstancedepends on
hashableversion.I think this is morally ok, as observing difference would require
downstream to depend on
hashable, thus they can differentiate.But that's however not entirely true, if one e.g. uses
Argas a key in
HashMap, yet one wouldn't with oldhashableas then
Hashable ArgandEq Argdisagree, so it probably doesn'twork anyway.