Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot implement StoreInterface's Invalidate method #175

Closed
sgtsquiggs opened this issue Oct 26, 2022 · 4 comments
Closed

Cannot implement StoreInterface's Invalidate method #175

sgtsquiggs opened this issue Oct 26, 2022 · 4 comments

Comments

@sgtsquiggs
Copy link
Contributor

Cannot figure out how we're supposed to implement Invalidate since the invalidation options are private. Cannot retrieve the tags that would be passed to the function.
@sgtsquiggs
Copy link
Contributor Author

I made some sloppy changes on my fork to expose it. I really don't like it but I needed it in a pinch.

master...sgtsquiggs:gocache:expose-invalidation-options

@denis111
Copy link

the same happens with Set(ctx context.Context, key any, object T, options ...store.Option) because I can't access Option members like expiration...

@sgtsquiggs
Copy link
Contributor Author

I'll submit a PR and we can get API feedback there.

@sgtsquiggs sgtsquiggs mentioned this issue Nov 12, 2022
Merged
@eko
Copy link
Owner

eko commented Dec 3, 2022

Hi, thanks to all the people working on this subject.

As options are now publicly available, this should be fixed.

I close this issue for now but feel free to reopen if you still have any issue.

@eko eko closed this as completed Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@eko @denis111 @sgtsquiggs