feat: Support for a key that would implement it's own key generator #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstead of the default md5 checksum
meDavidNS
changed the title
|
Hi @meDavidNS, This is cool, thank you! |
eko
approved these changes
Jan 16, 2022
|
Thank you @meDavidNS, I will add the section in README file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature request
Especially when using the LoadableCache, you would typically provide the arguments of the loadFunc as a key and inside the cache the key would be generated as the md5 checksum of the type and value when the key is not already a string. I would like the keys to be human readable and thus implement my owner type to string conversion.
With this PR the user is able to implent it's own
GetCacheKey()function when required. The only BC break I see is when an existing user already implemented this function and wasn't expeciting it to be used by the cache to generate the cache key.