chain set to run set on all cache stores #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashtonian
changed the title
|
I'm getting the following error trying to run locally: |
|
I don't have the error you paste when I checkout your branch, but 1 test is still failing: === RUN TestChainSetWhenErrorOnSetting
Error: chain.go:78: Unexpected call to *mocks.MockSetterCacheInterface[interface {}].Set([context.Background my-key 0xc0000976a0]) at /home/runner/work/gocache/gocache/cache/chain.go:78 because: there are no expected calls of the method "Set" for that receiver
--- FAIL: TestChainSetWhenErrorOnSetting (0.00s) |
eko
approved these changes
Jun 10, 2022
|
Thank you for adding this @ashtonian |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
messed up #140 here is a rebased version with corrections asked for.