Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: upgrade github.com/vmihailenco/msgpack to v5 #220

Merged
merged 1 commit into from Aug 28, 2023

Conversation

jaimem88
Copy link
Contributor

msgpack is now using modules as of v5+, this PR upgrades the library to the latest version v5.3.5. From the changelog, there are a few breaking changes, however, none of them affect the usage of the library here.

@jaimem88
Copy link
Contributor Author

go test ./...
ok  	github.com/eko/gocache/lib/v4/cache	1.544s
ok  	github.com/eko/gocache/lib/v4/codec	0.828s
ok  	github.com/eko/gocache/lib/v4/marshaler	0.587s
ok  	github.com/eko/gocache/lib/v4/metrics	1.512s
ok  	github.com/eko/gocache/lib/v4/store	1.659s

@jaimem88
Copy link
Contributor Author

@eko 👋 would you consider merging this PR?

@eko
Copy link
Owner

eko commented Aug 28, 2023

Thank you for this upgrade of msgpack @jaimem88

@eko eko merged commit a462cd8 into eko:master Aug 28, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants