Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ristretto Store] Add configurable synchronous write option #231

Merged
merged 1 commit into from Dec 9, 2023

Conversation

kmdrn7
Copy link
Contributor

@kmdrn7 kmdrn7 commented Nov 20, 2023

Add configurable option to ristretto cache store to be able to wait/blocks until all buffered writes have been applied.
ref: https://github.com/dgraph-io/ristretto/blob/main/cache.go#L219

Fixes : #207

Signed-off-by: Andika Ahmad Ramadhan <andikahmadr@gmail.com>
@kmdrn7 kmdrn7 force-pushed the configurable-ristretto-sync-write branch from fb5ef43 to 0fcb134 Compare November 23, 2023 01:46
Copy link
Owner

@eko eko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this addition @kmdrn7 amd sorry for the review delay!

@eko eko merged commit 002c243 into eko:master Dec 9, 2023
18 checks passed
@kmdrn7 kmdrn7 deleted the configurable-ristretto-sync-write branch February 3, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ristretto store doesn't work as expected
2 participants