Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kms-alias): support pagination #206

Merged
merged 1 commit into from
Jul 6, 2024
Merged

Conversation

ekristen
Copy link
Owner

@ekristen ekristen commented Jul 6, 2024

This adds pagination support to KMS Alias resource such that all aliases will be discovered and processed for removal.

Resolves #205

A user opened a PR upstream, but it can't apply cleanly anymore, and there are a lot of extra files, so unfortunately I manually implemented the changes. rebuy-de/aws-nuke#1113

@ekristen ekristen merged commit 0a60088 into main Jul 6, 2024
4 checks passed
@ekristen ekristen deleted the fix-kms-alias-pagination branch July 6, 2024 16:18
@ekristen
Copy link
Owner Author

ekristen commented Jul 6, 2024

🎉 This issue has been resolved in version 3.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing KMS alias - Alias pagination
1 participant