Test for enable toolkit flags/config

pkg/ctl/cmdutils/gitops.go

@@ -303,12 +303,12 @@ func NewGitOpsToolkitConfigLoader(cmd *Cmd) *GitOpsToolkitConfigLoader {
 		}
 
 		if l.cmd.ClusterConfig.Git.Toolkit == nil {
-			return nil
+			return errors.New("no configuration found for enable toolkit")
 		}
 
 		toolkit := l.cmd.ClusterConfig.Git.Toolkit
 		if toolkit.Repository == "" {
-			return ErrMustBeSet("git.toolkit.repo")
+			return ErrMustBeSet("git.toolkit.repository")
 		}
 
 		if toolkit.GitProvider == "" {

pkg/ctl/enable/toolkit.go

@@ -11,6 +11,10 @@ import (
 )
 
 func enableToolkit(cmd *cmdutils.Cmd) {
+	configureAndRun(cmd, toolkitInstall)
+}
+
+func configureAndRun(cmd *cmdutils.Cmd, runFunc func(cmd *cmdutils.Cmd) error) {
 	cmd.ClusterConfig = api.NewClusterConfig()
 	cmd.SetDescription(
 		"toolkit",
@@ -33,23 +37,27 @@ func enableToolkit(cmd *cmdutils.Cmd) {
 			return err
 		}
 
-		k8sClientSet, _, err := cmdutils.KubernetesClientAndConfigFrom(cmd)
-		if err != nil {
-			return err
-		}
+		return runFunc(cmd)
+	}
+}
 
-		logger.Info("eksctl version %s", version.GetVersion())
-		logger.Info("will install toolkit components on cluster %s", cmd.ClusterConfig.Metadata.Name)
+func toolkitInstall(cmd *cmdutils.Cmd) error {
+	logger.Info("eksctl version %s", version.GetVersion())
+	logger.Info("will install toolkit components on cluster %s", cmd.ClusterConfig.Metadata.Name)
 
-		installer, err := toolkit.New(k8sClientSet, cmd.ClusterConfig.Git)
-		if err != nil {
-			return err
-		}
+	k8sClientSet, _, err := cmdutils.KubernetesClientAndConfigFrom(cmd)
+	if err != nil {
+		return err
+	}
 
-		if err := installer.Run(); err != nil {
-			return err
-		}
+	installer, err := toolkit.New(k8sClientSet, cmd.ClusterConfig.Git)
+	if err != nil {
+		return err
+	}
 
-		return nil
+	if err := installer.Run(); err != nil {
+		return err
 	}
+
+	return nil
 }

pkg/ctl/enable/toolkit_test.go

@@ -0,0 +1,177 @@
+package enable
+
+import (
+	"os"
+
+	. "github.com/onsi/ginkgo"
+	. "github.com/onsi/gomega"
+
+	api "github.com/weaveworks/eksctl/pkg/apis/eksctl.io/v1alpha5"
+	. "github.com/weaveworks/eksctl/pkg/ctl/ctltest"
+)
+
+var _ = Describe("enable toolkit", func() {
+	var mockEnableToolkitCmd func(args ...string) *MockCmd
+
+	BeforeEach(func() {
+		mockEnableToolkitCmd = func(args ...string) *MockCmd {
+			return NewMockCmd(configureAndRun, "enable", args...)
+		}
+	})
+
+	When("--config-file is not provided", func() {
+		It("should fail", func() {
+			cmd := mockEnableToolkitCmd("toolkit")
+			out, err := cmd.Execute()
+			Expect(err).To(HaveOccurred())
+			Expect(err).To(MatchError("--config-file/-f <file> must be set"))
+			Expect(out).To(ContainSubstring("Usage"))
+		})
+	})
+
+	When("name arg is provided", func() {
+		It("should fail", func() {
+			cmd := mockEnableToolkitCmd("toolkit", "foo")
+			out, err := cmd.Execute()
+			Expect(err).To(HaveOccurred())
+			Expect(err).To(MatchError("name argument is not supported"))
+			Expect(out).To(ContainSubstring("Usage"))
+		})
+	})
+
+	When("--cluster is provided", func() {
+		It("should fail", func() {
+			cmd := mockEnableToolkitCmd("toolkit", "--cluster", "foo")
+			out, err := cmd.Execute()
+			Expect(err).To(HaveOccurred())
+			Expect(err).To(MatchError("unknown flag: --cluster"))
+			Expect(out).To(ContainSubstring("Usage"))
+		})
+	})
+
+	When("--region is provided", func() {
+		It("should fail", func() {
+			cmd := mockEnableToolkitCmd("toolkit", "--region", "foo")
+			out, err := cmd.Execute()
+			Expect(err).To(HaveOccurred())
+			Expect(err).To(MatchError("unknown flag: --region"))
+			Expect(out).To(ContainSubstring("Usage"))
+		})
+	})
+
+	When("--config-file is provided", func() {
+		var (
+			configFile string
+			cfg        *api.ClusterConfig
+
+			cmd *MockCmd
+			err error
+		)
+
+		BeforeEach(func() {
+			// Minimal valid cluster config for the command to work
+			cfg = &api.ClusterConfig{
+				TypeMeta: api.ClusterConfigTypeMeta(),
+				Metadata: &api.ClusterMeta{
+					Name:   "cluster-1",
+					Region: "us-west-2",
+				},
+				Git: &api.Git{
+					Toolkit: &api.Toolkit{
+						GitProvider: "github",
+						Repository:  "repo1",
+						Owner:       "username",
+					},
+				},
+			}
+		})
+
+		JustBeforeEach(func() {
+			configFile = CreateConfigFile(cfg)
+			cmd = mockEnableToolkitCmd("toolkit", "-f", configFile)
+			_, err = cmd.Execute()
+		})
+
+		AfterEach(func() {
+			Expect(os.Remove(configFile)).To(Succeed())
+		})
+
+		It("succeeds with the basic configuration", func() {
+			Expect(err).ToNot(HaveOccurred())
+
+			toolkitCfg := cmd.Cmd.ClusterConfig.Git.Toolkit
+			Expect(toolkitCfg).ToNot(BeNil())
+			Expect(toolkitCfg.Repository).To(Equal("repo1"))
+			Expect(toolkitCfg.GitProvider).To(Equal("github"))
+			Expect(toolkitCfg.Owner).To(Equal("username"))
+		})
+
+		It("loads the correct default", func() {
+			Expect(err).ToNot(HaveOccurred())
+
+			toolkitCfg := cmd.Cmd.ClusterConfig.Git.Toolkit
+			Expect(toolkitCfg).ToNot(BeNil())
+			Expect(toolkitCfg.Namespace).To(Equal("flux-system"))
+		})
+
+		When("metadata.cluster is not provided", func() {
+			BeforeEach(func() {
+				cfg.Metadata.Name = ""
+			})
+
+			It("fails", func() {
+				Expect(err).To(MatchError("metadata.name must be set"))
+			})
+		})
+
+		When("metadata.region is not provided", func() {
+			BeforeEach(func() {
+				cfg.Metadata.Region = ""
+			})
+
+			It("fails", func() {
+				Expect(err).To(MatchError("metadata.region must be set"))
+			})
+		})
+
+		When("git.toolkit is not provided", func() {
+			BeforeEach(func() {
+				cfg.Git.Toolkit = nil
+			})
+
+			It("fails", func() {
+				Expect(err).To(MatchError("no configuration found for enable toolkit"))
+			})
+		})
+
+		When("git.toolkit.gitProvider is not provided", func() {
+			BeforeEach(func() {
+				cfg.Git.Toolkit.GitProvider = ""
+			})
+
+			It("fails", func() {
+				Expect(err).To(MatchError("git.toolkit.gitProvider must be set"))
+			})
+		})
+
+		When("git.toolkit.repository is not provided", func() {
+			BeforeEach(func() {
+				cfg.Git.Toolkit.Repository = ""
+			})
+
+			It("fails", func() {
+				Expect(err).To(MatchError("git.toolkit.repository must be set"))
+			})
+		})
+
+		When("git.toolkit.owner is not provided", func() {
+			BeforeEach(func() {
+				cfg.Git.Toolkit.Owner = ""
+			})
+
+			It("fails", func() {
+				Expect(err).To(MatchError("git.toolkit.owner must be set"))
+			})
+		})
+	})
+})