Added fetch-depth to release workflows, small tag-* cleanup (#3181)

.github/workflows/release-candidate.yaml

@@ -13,6 +13,7 @@ jobs:
         uses: actions/checkout@v2
         with:
           token: ${{ secrets.WEAVEWORKSBOT_TOKEN }}
+          fetch-depth: 0
       - name: Cache go-build and mod
         uses: actions/cache@v2
         with:

.github/workflows/release.yaml

@@ -13,6 +13,7 @@ jobs:
         uses: actions/checkout@v2
         with:
           token: ${{ secrets.WEAVEWORKSBOT_TOKEN }}
+          fetch-depth: 0
       - name: Cache go-build and mod
         uses: actions/cache@v2
         with:

build/scripts/tag-common.sh

@@ -36,13 +36,6 @@ function check_current_branch() {
   fi
 }
 
-function ensure_exists() {
-  if ! git show-ref --verify --quiet "refs/heads/${1}"; then
-    echo "The ${1} branch must exist"
-    exit 7
-  fi
-}
-
 function ensure_up_to_date() {
   git pull --ff-only origin "$1"
 }

build/scripts/tag-release-candidate.sh

@@ -5,15 +5,12 @@ DIR="${BASH_SOURCE%/*}"
 # shellcheck source=tag-common.sh
 source "${DIR}/tag-common.sh"
 
-function create_branch_from_if_not_current() {
+function create_branch_from_if_doesnt_exist() {
   wanted_branch="$1"
   source_branch="$2"
-  if [ ! "$(current_branch)" = "${wanted_branch}" ] ; then
+  if ! git checkout "${wanted_branch}" >/dev/null; then
+      git checkout "${source_branch}"
       echo "Creating ${wanted_branch} from ${source_branch}"
-      if [ ! "$(current_branch)" = "${source_branch}" ] ; then
-        echo "Must be on ${source_branch} branch"
-        exit 7
-      fi
       git checkout -b "${wanted_branch}"
   fi
 }
@@ -25,14 +22,12 @@ release_notes_file=$(ensure_release_notes "${candidate_for_version}")
 # Check all conditions
 check_origin
 
-ensure_exists "${default_branch}"
-
-create_branch_from_if_not_current "${release_branch}" "${default_branch}"
-
 git checkout "${default_branch}"
 check_current_branch "${default_branch}"
 ensure_up_to_date "${default_branch}"
 
+create_branch_from_if_doesnt_exist "${release_branch}" "${default_branch}"
+
 git checkout "${release_branch}"
 check_current_branch "${release_branch}"
 ensure_up_to_date "${release_branch}" || echo "${release_branch} not found in origin, will push new branch upstream."

build/scripts/tag-release.sh

@@ -11,8 +11,6 @@ release_notes_file=$(ensure_release_notes "${release_version}")
 
 check_origin
 
-ensure_exists "${default_branch}"
-
 git checkout "${default_branch}"
 check_current_branch "${default_branch}"
 ensure_up_to_date "${default_branch}"