fix failing unit test

eksctl-io · Jan 18, 2021 · 8fc8dcb · 8fc8dcb
1 parent 67e7fd4
commit 8fc8dcb
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/pkg/actions/iam/update.go b/pkg/actions/iam/update.go
@@ -18,17 +18,17 @@ func (a *Manager) UpdateIAMServiceAccounts(iamServiceAccounts []*api.ClusterIAMS
 	var nonExistingSAs []string
 	updateTasks := &tasks.TaskTree{Parallel: true}
 
-	stacks, err := a.stackManager.ListStacksMatching("eksctl-.*-addon-iamserviceaccount")
+	existingIAMStacks, err := a.stackManager.ListStacksMatching("eksctl-.*-addon-iamserviceaccount")
 	if err != nil {
 		return err
 	}
 
-	existingStacksMap := listToSet(stacks)
+	existingIAMStacksMap := listToSet(existingIAMStacks)
 
 	for _, iamServiceAccount := range iamServiceAccounts {
 		stackName := makeIAMServiceAccountStackName(a.clusterName, iamServiceAccount.Namespace, iamServiceAccount.Name)
 
-		if _, ok := existingStacksMap[stackName]; !ok {
+		if _, ok := existingIAMStacksMap[stackName]; !ok {
 			logger.Info("Cannot update IAMServiceAccount %s/%s as it does not exist", iamServiceAccount.Namespace, iamServiceAccount.Name)
 			nonExistingSAs = append(nonExistingSAs, fmt.Sprintf("%s/%s", iamServiceAccount.Namespace, iamServiceAccount.Name))
 			continue

diff --git a/pkg/actions/iam/update_test.go b/pkg/actions/iam/update_test.go
@@ -58,7 +58,7 @@ var _ = Describe("Update", func() {
 			Expect(err).NotTo(HaveOccurred())
 
 			Expect(fakeStackManager.ListStacksMatchingCallCount()).To(Equal(1))
-			Expect(fakeStackManager.ListStacksMatchingArgsForCall(0)).To(Equal("eksctl-my-cluster-addon-iamserviceaccount-default-test-sa"))
+			Expect(fakeStackManager.ListStacksMatchingArgsForCall(0)).To(Equal("eksctl-.*-addon-iamserviceaccount"))
 			Expect(fakeStackManager.UpdateStackCallCount()).To(Equal(1))
 			fakeStackManager.UpdateStackArgsForCall(0)
 			stackName, changeSetName, description, templateData, _ := fakeStackManager.UpdateStackArgsForCall(0)
@@ -82,7 +82,7 @@ var _ = Describe("Update", func() {
 				Expect(err).NotTo(HaveOccurred())
 
 				Expect(fakeStackManager.ListStacksMatchingCallCount()).To(Equal(1))
-				Expect(fakeStackManager.ListStacksMatchingArgsForCall(0)).To(Equal("eksctl-my-cluster-addon-iamserviceaccount-default-test-sa"))
+				Expect(fakeStackManager.ListStacksMatchingArgsForCall(0)).To(Equal("eksctl-.*-addon-iamserviceaccount"))
 				Expect(fakeStackManager.UpdateStackCallCount()).To(Equal(0))
 			})
 		})