Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use aws-iam-authenticator as default once new version is out #169

Closed
errordeveloper opened this issue Aug 20, 2018 · 11 comments · Fixed by #754
Closed

use aws-iam-authenticator as default once new version is out #169

errordeveloper opened this issue Aug 20, 2018 · 11 comments · Fixed by #754
Assignees
@errordeveloper
Labels
area/aws-iam area/general-cli
Milestone
v1alpha5

Comments

@errordeveloper
Copy link
Contributor

kubernetes-sigs/aws-iam-authenticator#119
@errordeveloper errordeveloper added this to the 0.1.x – improvements milestone Aug 20, 2018
@errordeveloper errordeveloper self-assigned this Aug 20, 2018
@errordeveloper
Copy link
Contributor Author

We should also update the library.

@praveencbe0
Copy link

praveencbe0 commented Aug 21, 2018 •
edited
Loading

Getting heptio-authenticator-aws not installed when trying to create cluster.
Unable to install heptio-authenticator-aws since it is removed from github.
Able to install aws-iam-authenticator but eksctl is not using it.

I see the merge has been pushed but it has not been released. It is being a hard blocker for us.

Thanks.

@errordeveloper
Copy link
Contributor Author

errordeveloper commented Aug 21, 2018 •
edited
Loading

Unable to install heptio-authenticator-aws since it is removed from github.

Not true. The binaries are here: https://github.com/kubernetes-sigs/aws-iam-authenticator/releases/tag/v0.3.0

And here for Windows: https://amazon-eks.s3-us-west-2.amazonaws.com/1.10.3/2018-07-26/bin/windows/amd64/heptio-authenticator-aws.exe

Able to install aws-iam-authenticator but eksctl is not using it.
I see the merge has been pushed but it has not been released. It is being a hard blocker for us.

You will be able to do this soon, once we release 0.1.1, probably before end of this week. You can build from master also, if you don't mind, and have Go toolchain installed (go get github.com/weaveworks/eksctl/cmd/eksctl should be sufficient).

But it's much easier to install heptio-authenticator-aws from one of the links above.

@arun-gupta
Copy link

Looking forward to 0.1.1 release

@tsal
Copy link

tsal commented Sep 10, 2018 •
edited
Loading

editing the generated configuration to use aws-iam-authenticator seems to solve this issue just fine.

that said, 0.1.1 does not seem to fix this.

richardcase added a commit that referenced this issue Sep 12, 2018
@richardcase
AMI resolution and overriding (allowing GPU support) (#192)
6772a2b 
The `--node-ami` flag has been added and can be used to supply an ami id to use. There are
2 special values that can be passed as well:

- 'static' which is the default and it will make sure the static
resolvers are used (which uses embedded image ids)
- 'auto' which instructs eksctl to use the 'auto' resolver (which queries AWS).

If neither of these special values are supplied to the flag then we take it as a excplicit AMI image id that should be used for the EKS nodes.

The 'static' and 'auto' resolvers can resolve instance types with GPU support (p2/p3) and use an AMI image that is optimized with GPU support. If using the GPU instances then the [NVIDIA device plugin](https://github.com/NVIDIA/k8s-device-plugin) will still need to be installed manually. Instructions are output. This will be an 'addon' in the future.

The ami's used for non-gpu instances have been updated to use the v23 version of the images. Also added the image for eu-west-1.

The static resolvers use maps to aid future go generate code which will aid #49.

After changing the AMIs to v23 a change has been made to use aws-iam-authenticator instead of heptio-authenticator-aws.

Also, AMI resolution is done earlier before the stack is started to be built...fail fast. Also added code to check the resolved image exists.

Issue #183 
Issue #197 
Issue #194
Issue #169
@arun-gupta
Copy link

0.1.2 does not seem to fix this as well. What is the ETA?

@errordeveloper
Copy link
Contributor Author

@arun-gupta kubernetes-sigs/aws-iam-authenticator#119 is still open also. I would rather avoid creating a work-around, unless the chances of kubernetes-sigs/aws-iam-authenticator#119 being fixed in the next month are too low.

@arun-gupta
Copy link

Created a new cluster using eksctl and seems like this renaming is no longer required.

2018-12-14T18:17:31-06:00 [ℹ]  versionInfo = map[string]string{"gitCommit":"191474b2b0a6e6856b5f9c652c38b5f2f01bf7c9", "gitTag":"0.1.11", "builtAt":"2018-11-09T16:15:40Z"}

Should this still be open?

@errordeveloper errordeveloper mentioned this issue Dec 17, 2018
Closed
@errordeveloper
Copy link
Contributor Author

Yes, this should be open until authenticator 0.4.0 is out and kubernetes-sigs/aws-iam-authenticator#119 closed, so that we can delete all references to heptio-authenticator-aws.

@errordeveloper
Copy link
Contributor Author

Looks like 0.4.0-alpha.1 was released in October, but no new releases since then.

@errordeveloper errordeveloper mentioned this issue Apr 2, 2019
Closed
@redborian redborian mentioned this issue Apr 12, 2019
Closed
@errordeveloper
Copy link
Contributor Author

0.4.0 is out now, we should try to add this for the next release.

@errordeveloper errordeveloper mentioned this issue Apr 26, 2019
Merged
3 tasks
arun-gupta added a commit to arun-gupta/kubernetes-for-java-developers that referenced this issue Apr 27, 2019
@arun-gupta
eksctl-io/eksctl#169 is now fixed and so cleaning up instructions
ef887ac
RezaEskandarii5rk7k added a commit to RezaEskandarii5rk7k/aws-samples that referenced this issue Dec 11, 2021
@RezaEskandarii5rk7k
eksctl-io/eksctl#169 is now fixed and so cleaning up instructions
7c9285c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@errordeveloper errordeveloper

Labels
area/aws-iam area/general-cli
Projects
None yet
Milestone
v1alpha5
Development

Successfully merging a pull request may close this issue.

Update authenticator to 0.4.0 eksctl-io/eksctl
4 participants
@arun-gupta @errordeveloper @tsal @praveencbe0