Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking Proposal #002: Existing VPC #306

Closed
1 of 7 tasks
errordeveloper opened this issue Nov 6, 2018 · 2 comments
Closed
1 of 7 tasks

Tracking Proposal #002: Existing VPC #306

errordeveloper opened this issue Nov 6, 2018 · 2 comments
Labels
area/aws-vpc help wanted Extra attention is needed

Comments

@errordeveloper
Copy link
Contributor

errordeveloper commented Nov 6, 2018

This is an umbrella issue is for tracking progress on custom VPC features as proposed in #303.


  • --vpc-{private,public}-subnets (initial baseline feature): Enable use of existing subnets #305
  • --vpc-id=default (use default VPC and all of its existing subnets)
  • --vpc-id=default with --vpc-{private,public}-subnets (use default VPC, but given subnet IDs)
  • --vpc-id="vpc-xxx" (use given VPC, create dedicated subnets)
  • --vpc-id="vpc-xxx" with --vpc-{private,public}-subnets (use given VPC ID, and given subnets - an explicit/logical option)
  • eksctl <create|get|delete> vpc --name=<vpcName> (manage shared VPCs)
  • eksctl create cluster --vpc-name=<vpcName> (create cluster in a shared VPC)
@errordeveloper errordeveloper changed the title tracking proposal #002: Existing VPC Tracking Proposal #002: Existing VPC Nov 6, 2018
@errordeveloper errordeveloper added the help wanted Extra attention is needed label Nov 6, 2018
@errordeveloper errordeveloper added this to the 0.1.x – improvements milestone Nov 6, 2018
@mumoshu
Copy link
Contributor

mumoshu commented Nov 30, 2018

I love eksctl's ability to use pre-created subnets. Nice!

However, I'd suggest not to do this:

--vpc-id="vpc-xxx" (use given VPC, create dedicated subnets)

This seems like a shoot-youself-in-the-foot. I've once encountered my kube-aws user who unintentionally created an unmovable, important AWS resource - RDS DB instance - in the subnet kube-aws has created and managed by CloudFormation. They can never destroy the cfn stack...

@martina-if
Copy link
Contributor

Most of the things in this issue have been implemented or there are other issues for tracking them so I will close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/aws-vpc help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants