Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design Proposal #002: Existing VPC #303

Merged
merged 1 commit into from
Nov 6, 2018
Merged

Design Proposal #002: Existing VPC #303

merged 1 commit into from
Nov 6, 2018

Conversation

errordeveloper
Copy link
Contributor

No description provided.

@anodyne4j
Copy link

This looks really cool, @errordeveloper, and it has all the flags I'd need for the cluster I'm bringing up.

One question - could we run into issues deploying into existing subnets while using EKS-native CNI, with its need for many secondary IPs? What would happen if all the pods in the cluster weren't able to get IP addrs?

@errordeveloper
Copy link
Contributor Author

errordeveloper commented Nov 5, 2018

@anodyne4j thanks a lot for your feedback!

One question - could we run into issues deploying into existing subnets while using EKS-native CNI, with its need for many secondary IPs? What would happen if all the pods in the cluster weren't able to get IP addrs?

I am not deeply familiar with the implementation, but I am pretty certain it's meant to coexist very happily with anything you have in your VPC, from plain EC2 instances, through load balancers and gateways to Lambda functions. So I would expect it to try and use what IP addresses are available, which is only a subject to IP address space usage, of course. You can monitor allocations (and other properties of the CNI driver) via CloudWatch (#278) and/or Prometheus.

However, if you have a short subnet in your VPC, or there are many resources using up the IP address space, you will ultimately run into issue sooner than later. If that's the case, I would consider VPC peering, or something else. Peering should already be possible, and custom CIDR flag is available as of 0.1.8.

And, I must note, that exactly for this and other reasons we have plans to provide Weave Net as an overall option (#109, weaveworks/weave#3335). By definition overall is exactly for this purposes. I am not up to date on IPv6 support in EKS, I've not heard of it being commonly used in AWS just yet, but I'm keen to hear if anyone used it.

@errordeveloper errordeveloper force-pushed the proposal-002 branch 3 times, most recently from ba9e128 to 9ae9124 Compare November 6, 2018 09:39
@errordeveloper
Copy link
Contributor Author

I've clarified that this is still a draft and changes are welcome. I'd like to merge it soon, as well as --vpc-{private,public}-subnets implementation.

@errordeveloper errordeveloper force-pushed the proposal-002 branch 5 times, most recently from 053c38d to 091cdd2 Compare November 6, 2018 10:22
@errordeveloper
Copy link
Contributor Author

I'm going to merge this, as this doesn't imply we have made a final decision. There is more we can do, and tweaks are welcome. Initial feature is underway in #305, let's use #306 to tracking progress on various features listed in this document.

@errordeveloper errordeveloper merged commit 33d350d into master Nov 6, 2018
@errordeveloper errordeveloper deleted the proposal-002 branch November 6, 2018 17:24
torredil pushed a commit to torredil/eksctl that referenced this pull request May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants