Add completion support for fish #2025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayboras
force-pushed
the
feature/fish-completion
branch
from
6b361cf
to
abca1be
Compare
sayboras
force-pushed
the
feature/fish-completion
branch
from
abca1be
to
2864854
Compare
sayboras
commented
Apr 11, 2020
| @@ -37,7 +37,7 @@ require ( | |||
| github.com/pkg/errors v0.9.1 | |||
| github.com/riywo/loginshell v0.0.0-20190610082906-2ed199a032f6 | |||
| github.com/spf13/afero v1.2.2 | |||
| github.com/spf13/cobra v0.0.6 | |||
| github.com/spf13/cobra v1.0.0 | |||
There was a problem hiding this comment.
https://github.com/spf13/cobra/releases/tag/v1.0.0 just released today 🎉
sayboras
commented
Apr 11, 2020
| @@ -26,7 +24,7 @@ If you are stuck on Bash 3 (macOS) use | |||
| source /dev/stdin <<<"$(eksctl completion bash)" | |||
| `, | |||
| RunE: func(cmd *cobra.Command, args []string) error { | |||
| return rootCmd.GenBashCompletion(os.Stdout) | |||
| return rootCmd.GenBashCompletion(cmd.OutOrStdout()) | |||
There was a problem hiding this comment.
Use output from cmd for testability
sayboras
force-pushed
the
feature/fish-completion
branch
5 times, most recently
from
bebd5db
to
41bbd5d
Compare
Add missing unit test for completion CLI Update shell installation docs
sayboras
force-pushed
the
feature/fish-completion
branch
from
41bbd5d
to
ed3e7bc
Compare
|
@martina-if @cPu1 your review is highly appreciated 👍 |
martina-if
approved these changes
Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1496
Checklist
README.md, or thesite/contentdirectory)area/nodegroup), target version (e.g.version/0.12.0) and kind (e.g.kind/improvement)