Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated default kubelet reserved memory calculation to match the calculation used by amazon-eks-ami #2443

Merged

Commits on Jul 16, 2020

  1. The reserved memory calculation was changed in amazon-eks-ami to be b…

    …ased on pod density
    
    (11*maxPodsPerNode+255) instead of total memory.
    See https://github.com/awslabs/amazon-eks-ami/blob/21426e27e3845319dbca92e7df32e5c4b984a1d1/files/bootstrap.sh#L163
    
    This commit introduces a new MaxPodsPerNode property on InstanceTypeInfo and populates it
    using the data from maxpods.go so that it will be available for calculating the default memory
    to reserve. It removes the Memory property from InstanceTypeInfo because it is no longer needed.
    
    This commit also updates related unit tests. It fixes some unit tests which reference instance types which no
    longer exist and adds a check to make sure instance types which are expected to exist actually exist, and those
    which are not expected to exist do not exist.
    brianpursley committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    6bf3afb View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2020

  1. Configuration menu
    Copy the full SHA
    c72bc0a View commit details
    Browse the repository at this point in the history