Fix notify-slack only_for_branches option #2493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think there was an issue with the default being used when passing `""`. Now, without a default, settings are more explicit.
michaelbeaumont
added
area/build-and-release
skip-release-notes
martina-if
approved these changes
Jul 30, 2020
michaelbeaumont
added a commit
that referenced
this pull request
Aug 3, 2020
* Fix circleci commands * Tag 0.25.0-rc.0 release candidate * Fix release circleci notifications (#2479) * Fix notify-slack only_for_branches option (#2493) I think there was an issue with the default being used when passing `""`. Now, without a default, settings are more explicit. * Add EKS private cluster usage to sidebar (#2491) Co-authored-by: Mike Beaumont <mjboamail@gmail.com> * Add support for Milan (eu-south-1) and Cape Town (af-south-1) regions (#2495) Co-authored-by: Mike Beaumont <mjboamail@gmail.com> * Allow service role some actions necessary for ELB (#2492) * Update 0.25 release notes (#2498) * Release 0.25.0 Co-authored-by: Chetan Patwal <cPu1@users.noreply.github.com> Co-authored-by: Martina Iglesias <martina-if@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I think there was an issue with the default being used when
passing
"". Now, without a default, settings are more explicit.Checklist
README.md, or theuserdocsdirectory)area/nodegroup), target version (e.g.version/0.12.0) and kind (e.g.kind/improvement)