Add option to not rollback failed stacks #2744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelbeaumont
force-pushed
the
cfn_rollback
branch
2 times, most recently
from
11e67f7
to
1f71a73
Compare
michaelbeaumont
force-pushed
the
cfn_rollback
branch
from
1f71a73
to
f0e183a
Compare
cPu1
reviewed
Oct 16, 2020
pkg/cfn/manager/api.go
Outdated
Comment on lines
91
to
93
| if c.provider.CloudFormationOnFailureDoNothing() { | ||
| input.OnFailure = aws.String(cloudformation.OnFailureDoNothing) | ||
| } |
There was a problem hiding this comment.
Alternatively:
Suggested change
| if c.provider.CloudFormationOnFailureDoNothing() { | |
| input.OnFailure = aws.String(cloudformation.OnFailureDoNothing) | |
| } | |
| input.DisableRollback = aws.Bool(c.provider.CloudFormationOnFailureDoNothing()) |
There was a problem hiding this comment.
true, switched it over and just renamed to --cfn-disable-rollback
cPu1
approved these changes
Oct 16, 2020
michaelbeaumont
force-pushed
the
cfn_rollback
branch
from
a2511ef
to
bc05a17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
README.md, or theuserdocsdirectory)area/nodegroup), target version (e.g.version/0.12.0) and kind (e.g.kind/improvement)