Handle create nodegroup and withOIDC for clusters without aws-node SA #2778

michaelbeaumont · 2020-10-28T12:32:46Z

Added tests that cover your change (if possible)
Added/modified documentation as required (such as the README.md, or the userdocs directory)
Manually tested
Added labels for change area (e.g. area/nodegroup), target version (e.g. version/0.12.0) and kind (e.g. kind/improvement)
Make sure the title of the PR is a good description that can go into the release notes

aclevername

LGTM

michaelbeaumont requested a review from cPu1 October 28, 2020 12:32

michaelbeaumont added the kind/bug label Oct 28, 2020

michaelbeaumont force-pushed the withoidc_old branch from 493954a to 9a522d5 Compare October 28, 2020 12:47

michaelbeaumont changed the base branch from release-0.30 to release-0.31 October 28, 2020 12:47

michaelbeaumont force-pushed the withoidc_old branch 4 times, most recently from 72ca680 to 51f1ec8 Compare October 28, 2020 16:45

michaelbeaumont marked this pull request as ready for review October 28, 2020 16:46

aclevername self-requested a review October 28, 2020 16:46

cPu1 approved these changes Oct 28, 2020

View reviewed changes

michaelbeaumont force-pushed the withoidc_old branch from 51f1ec8 to 6ebb35e Compare October 28, 2020 16:48

michaelbeaumont added 3 commits October 28, 2020 17:51

Handle withOIDC for clusters without aws-node SA

780f16d

Adjust tests

e5a1926

Make nodegroup task naming consistent

1da25a5

michaelbeaumont force-pushed the withoidc_old branch from 6ebb35e to 1da25a5 Compare October 28, 2020 16:51

michaelbeaumont added the autosquash label Oct 28, 2020

aclevername approved these changes Oct 28, 2020

View reviewed changes

michaelbeaumont merged commit 3db6e0d into release-0.31 Oct 28, 2020

michaelbeaumont deleted the withoidc_old branch October 28, 2020 17:07

Provide feedback