Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release notes for 45 #3550

Merged
merged 3 commits into from Apr 9, 2021
Merged

Add release notes for 45 #3550

merged 3 commits into from Apr 9, 2021

Conversation

Callisto13
Copy link
Contributor

Please check that everything is there which should be. let me know if anything is missing.

@Callisto13 Callisto13 added the skip-release-notes Causes PR not to show in release notes label Apr 9, 2021
@cPu1
Copy link
Collaborator

cPu1 commented Apr 9, 2021

I'd like to get #3544 out in this release.

@Callisto13
Copy link
Contributor Author

Callisto13 commented Apr 9, 2021

I'd like to get #3544 out in this release.

Yep just getting pieces ready to go. Can you have that merged in the next 1hr 15 mins?

docs/release_notes/0.45.0.md Outdated Show resolved Hide resolved
Co-authored-by: Chetan Patwal <cPu1@users.noreply.github.com>
@Callisto13 Callisto13 enabled auto-merge (squash) April 9, 2021 13:40
@Callisto13 Callisto13 merged commit bb9e450 into main Apr 9, 2021
@Callisto13 Callisto13 deleted the notes-45 branch April 9, 2021 13:55
Copy link
Contributor

@lloydchang lloydchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Callisto13 @cPu1 @aclevername

Would you kindly amend the release notes as follows?

• Add #3519 next to #3516 in Bug Fixes
• Add me to Acknowledgements so when the release is finalized, then I get a GitHub notification?

Thank you.

## Bug Fixes
- Support comma separated array for group flag in create iamidentitymapping (#3549)
- Add capacity-optimized-prioritized (#3516, #3519)
## Acknowledgments
Weaveworks would like to sincerely thank:
  @omnibrian, @lloydchang


## Bug Fixes
- Support comma separated array for group flag in create iamidentitymapping (#3549)
- Add capacity-optimized-prioritized (#3516)

This comment was marked as outdated.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Add capacity-optimized-prioritized (#3516)
- Add capacity-optimized-prioritized (#3519)


## Acknowledgments
Weaveworks would like to sincerely thank:
@omnibrian
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@omnibrian
@omnibrian, @lloydchang

@Callisto13
Copy link
Contributor Author

Callisto13 commented Apr 10, 2021

Hi @lloydchang ! Sorry must have missed your name when I was prepping the notes 🤦‍♀️, I will add it on Monday .

We don't include the issues in release notes, just PRs, so having 3516 is enough here.

Copy link
Contributor

@lloydchang lloydchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Callisto13 #3519 is the PR, whereas #3516 is the bug report. Here's an additional commit suggestion for the release notes. Thank you!


## Bug Fixes
- Support comma separated array for group flag in create iamidentitymapping (#3549)
- Add capacity-optimized-prioritized (#3516)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Add capacity-optimized-prioritized (#3516)
- Add capacity-optimized-prioritized (#3519)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-release-notes Causes PR not to show in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants