New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add release notes for 45 #3550
Add release notes for 45 #3550
Conversation
I'd like to get #3544 out in this release. |
Yep just getting pieces ready to go. Can you have that merged in the next 1hr 15 mins? |
Co-authored-by: Chetan Patwal <cPu1@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Callisto13 @cPu1 @aclevername
Would you kindly amend the release notes as follows?
• Add #3519 next to #3516 in Bug Fixes
• Add me to Acknowledgements so when the release is finalized, then I get a GitHub notification?
Thank you.
## Bug Fixes
- Support comma separated array for group flag in create iamidentitymapping (#3549)
- Add capacity-optimized-prioritized (#3516, #3519)
## Acknowledgments
Weaveworks would like to sincerely thank:
@omnibrian, @lloydchang
|
||
## Bug Fixes | ||
- Support comma separated array for group flag in create iamidentitymapping (#3549) | ||
- Add capacity-optimized-prioritized (#3516) |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Add capacity-optimized-prioritized (#3516) | |
- Add capacity-optimized-prioritized (#3519) |
|
||
## Acknowledgments | ||
Weaveworks would like to sincerely thank: | ||
@omnibrian |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@omnibrian | |
@omnibrian, @lloydchang |
Hi @lloydchang ! Sorry must have missed your name when I was prepping the notes 🤦♀️, I will add it on Monday . We don't include the issues in release notes, just PRs, so having 3516 is enough here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Callisto13 #3519 is the PR, whereas #3516 is the bug report. Here's an additional commit suggestion for the release notes. Thank you!
|
||
## Bug Fixes | ||
- Support comma separated array for group flag in create iamidentitymapping (#3549) | ||
- Add capacity-optimized-prioritized (#3516) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Add capacity-optimized-prioritized (#3516) | |
- Add capacity-optimized-prioritized (#3519) |
Please check that everything is there which should be. let me know if anything is missing.