Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor cfn template tests #3589

Merged
merged 4 commits into from
Apr 19, 2021
Merged

Conversation

Callisto13
Copy link
Contributor

@Callisto13 Callisto13 commented Apr 16, 2021

Description

Quite a big diff, but no code is new (I did rearrange some stuff, but that's it).

This is simply a test refactor. It may not be perfect (I got quite tired towards the end and I held off tackling everything as I didn't want to make the diff even bigger), but hopefully it makes this little piece a bit better and easier to add tests to.

These tests are still not great, and that is in part due to the way the package is designed which leads to various things being all tangled up.

Good things:

  • More test coverage
  • Can now actually focus tests in here
  • Easier to add to (I hope)
  • My vim does not crash!

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 馃く

  • Backfilled missing tests for code in same general area 馃帀
  • Refactored something and made the world a better place 馃専

@Callisto13 Callisto13 added technical debt skip-release-notes Causes PR not to show in release notes labels Apr 16, 2021
@Callisto13 Callisto13 linked an issue Apr 16, 2021 that may be closed by this pull request
@Callisto13 Callisto13 requested a review from a team April 19, 2021 11:28
@Callisto13
Copy link
Contributor Author

i don't believe for a second that you read any of that @aclevername

@aclevername
Copy link
Contributor

i don't believe for a second that you read any of that @aclevername

I read all the It(".. and Context(".. and was happy enough.

@Callisto13
Copy link
Contributor Author

hmmm i'll allow it

@Callisto13 Callisto13 merged commit 99388c4 into eksctl-io:main Apr 19, 2021
@Callisto13 Callisto13 deleted the refactor-cfn-tests branch April 20, 2021 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-release-notes Causes PR not to show in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor pkg/cfn/builder tests
3 participants