Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use public repo for neuron device plugin image #3661

Merged
merged 3 commits into from
May 6, 2021
Merged

Use public repo for neuron device plugin image #3661

merged 3 commits into from
May 6, 2021

Conversation

aws-vrnatham
Copy link
Contributor

@aws-vrnatham aws-vrnatham commented May 4, 2021

Signed-off-by: vrnatham 73142315+aws-vrnatham@users.noreply.github.com

Description

For the neuron device plugin repos in us-east-1/us-west-2 is used. Neuron device plugin images are now available in public repo and so start using that.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 馃く

  • Backfilled missing tests for code in same general area 馃帀
  • Refactored something and made the world a better place 馃専

Signed-off-by: vrnatham <73142315+aws-vrnatham@users.noreply.github.com>
@Callisto13 Callisto13 changed the title neuron: use public repo for neuron device plugin Use public repo for neuron device plugin image May 4, 2021
@aclevername aclevername merged commit a58b3fc into eksctl-io:main May 6, 2021
@aclevername
Copy link
Contributor

Thanks @aws-vrnatham !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants