Upgrade non-al2 managed nodegroups by updating the Version field in the nodegroup stack
#4666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aclevername
changed the title
aclevername
changed the title
Version field in the nodegroup stack
aclevername
force-pushed
the
update-br-nodes
branch
3 times, most recently
from
cfb0e56
to
fb0ff31
Compare
aclevername
requested review from
cPu1,
Himangini,
nikimanoledaki and
Skarlso
aclevername
force-pushed
the
update-br-nodes
branch
from
fb0ff31
to
ec28a65
Compare
aclevername
changed the title
Version field in the nodegroup stackVersion field in the nodegroup stack
aclevername
force-pushed
the
update-br-nodes
branch
from
ec28a65
to
f7f756e
Compare
aclevername
force-pushed
the
update-br-nodes
branch
from
3e47cbf
to
0ceeeb8
Compare
Skarlso
reviewed
Jan 24, 2022
| "--kubernetes-version", nextVersion, | ||
| ) | ||
| Expect(cmd).To(RunSuccessfullyWithOutputString(ContainSubstring("nodegroup successfully upgraded"))) | ||
| upgradeNg := func(ngName string) { |
There was a problem hiding this comment.
Look at you going all functiony
There was a problem hiding this comment.
😂😂😂😂 was that or for loop . For loop felt wrong
Skarlso
reviewed
Jan 24, 2022
Skarlso
approved these changes
Jan 26, 2022
thanks! Waiting for a 2nd reviewer as this PR has a slightly bigger implication |
cPu1
approved these changes
Jan 31, 2022
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #4423. To upgrade non-al2 nodegroups we update the
Versionfield in the template to the correct kubernetes versions