Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in error message for IAM service account #5555

Merged
merged 2 commits into from
Aug 1, 2022
Merged

Fix typo in error message for IAM service account #5555

merged 2 commits into from
Aug 1, 2022

Conversation

wo-o
Copy link
Contributor

@wo-o wo-o commented Jul 30, 2022

Description

Dear team, I found some tiny typo. Please kindly consider confirming.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello jinnuae40 👋 Thank you for opening a Pull Request in eksctl project. The team will review the Pull Request and aim to respond within 1-5 business days. Meanwhile, please read about the Contribution and Code of Conduct guidelines here. You can find out more information about eksctl on our website

Copy link
Collaborator

@cPu1 cPu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted. Thanks for the contribution!

@cPu1 cPu1 changed the title Fix typo Fix typo in error message for IAM service account Aug 1, 2022
@cPu1 cPu1 enabled auto-merge (squash) August 1, 2022 08:21
@cPu1 cPu1 disabled auto-merge August 1, 2022 08:21
@cPu1 cPu1 enabled auto-merge (squash) August 1, 2022 08:21
@Himangini Himangini disabled auto-merge August 1, 2022 10:51
@Himangini
Copy link
Collaborator

@jinnuae40 thanks for the contribution, can you please update your branch we will get this merged shortly.

@wo-o
Copy link
Contributor Author

wo-o commented Aug 1, 2022

Dear @Himangini, I update the branch. Please feel free to let me know if there is anything to request.
Thank you !!!

@Himangini Himangini merged commit 0198572 into eksctl-io:main Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants