Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade sourcegraph/go-diff from 0.6.2 to 0.7.1 #6644

Merged
merged 2 commits into from
May 25, 2023

Conversation

joneidaws
Copy link
Contributor

@joneidaws joneidaws commented May 24, 2023

Description

I am bumping the minor version of the indirect sourcegraph/go-diff dependency from 0.6.2 to 0.7.1 as this new minor version removes unused dependencies without a LICENSE file, github.com/shurcooL/go and github.com/shurcooL/go-goon. Installed using go get github.com/sourcegraph/go-diff@1b4d09c

go test ./pkg/... passes

joneid@c889f3b6bbde eksctl-private % go test ./pkg/...
ok      github.com/weaveworks/eksctl/pkg/actions/addon  (cached)
ok      github.com/weaveworks/eksctl/pkg/actions/anywhere       (cached)
ok      github.com/weaveworks/eksctl/pkg/actions/cluster        (cached)
?       github.com/weaveworks/eksctl/pkg/actions/cluster/fakes  [no test files]
ok      github.com/weaveworks/eksctl/pkg/actions/fargate        (cached)
ok      github.com/weaveworks/eksctl/pkg/actions/flux   (cached)
?       github.com/weaveworks/eksctl/pkg/actions/flux/fakes     [no test files]
?       github.com/weaveworks/eksctl/pkg/actions/iamidentitymapping     [no test files]
ok      github.com/weaveworks/eksctl/pkg/actions/identityproviders      (cached)
ok      github.com/weaveworks/eksctl/pkg/actions/irsa   (cached)
ok      github.com/weaveworks/eksctl/pkg/actions/karpenter      (cached)
?       github.com/weaveworks/eksctl/pkg/actions/karpenter/fakes        [no test files]
ok      github.com/weaveworks/eksctl/pkg/actions/label  (cached)
?       github.com/weaveworks/eksctl/pkg/actions/label/fakes    [no test files]
ok      github.com/weaveworks/eksctl/pkg/actions/nodegroup      (cached)
?       github.com/weaveworks/eksctl/pkg/addons [no test files]
ok      github.com/weaveworks/eksctl/pkg/addons/default (cached)
ok      github.com/weaveworks/eksctl/pkg/ami    (cached)
?       github.com/weaveworks/eksctl/pkg/apis/eksctl.io [no test files]
ok      github.com/weaveworks/eksctl/pkg/apis/eksctl.io/v1alpha5        (cached)
?       github.com/weaveworks/eksctl/pkg/apis/eksctl.io/v1alpha5/fakes  [no test files]
?       github.com/weaveworks/eksctl/pkg/assetutil      [no test files]
ok      github.com/weaveworks/eksctl/pkg/authconfigmap  (cached)
?       github.com/weaveworks/eksctl/pkg/awsapi [no test files]
?       github.com/weaveworks/eksctl/pkg/awsapi/generate        [no test files]
ok      github.com/weaveworks/eksctl/pkg/az     (cached)
ok      github.com/weaveworks/eksctl/pkg/cfn/builder    (cached)
?       github.com/weaveworks/eksctl/pkg/cfn/builder/fakes      [no test files]
ok      github.com/weaveworks/eksctl/pkg/cfn/manager    (cached)
?       github.com/weaveworks/eksctl/pkg/cfn/manager/fakes      [no test files]
ok      github.com/weaveworks/eksctl/pkg/cfn/outputs    (cached)
ok      github.com/weaveworks/eksctl/pkg/cfn/template   (cached)
?       github.com/weaveworks/eksctl/pkg/cfn/template/matchers  [no test files]
ok      github.com/weaveworks/eksctl/pkg/cfn/waiter     (cached)
ok      github.com/weaveworks/eksctl/pkg/cloudconfig    (cached)
ok      github.com/weaveworks/eksctl/pkg/connector      (cached)
ok      github.com/weaveworks/eksctl/pkg/credentials    (cached)
?       github.com/weaveworks/eksctl/pkg/credentials/fakes      [no test files]
?       github.com/weaveworks/eksctl/pkg/ctl/associate  [no test files]
ok      github.com/weaveworks/eksctl/pkg/ctl/cmdutils   (cached)
ok      github.com/weaveworks/eksctl/pkg/ctl/cmdutils/filter    (cached)
?       github.com/weaveworks/eksctl/pkg/ctl/cmdutils/filter/fakes      [no test files]
?       github.com/weaveworks/eksctl/pkg/ctl/cmdutils/filter/filterfakes        [no test files]
ok      github.com/weaveworks/eksctl/pkg/ctl/completion (cached)
ok      github.com/weaveworks/eksctl/pkg/ctl/create     (cached)
?       github.com/weaveworks/eksctl/pkg/ctl/ctltest    [no test files]
ok      github.com/weaveworks/eksctl/pkg/ctl/delete     (cached)
?       github.com/weaveworks/eksctl/pkg/ctl/deregister [no test files]
ok      github.com/weaveworks/eksctl/pkg/ctl/disassociate       (cached) [no tests to run]
ok      github.com/weaveworks/eksctl/pkg/ctl/drain      (cached)
ok      github.com/weaveworks/eksctl/pkg/ctl/enable     (cached)
ok      github.com/weaveworks/eksctl/pkg/ctl/get        (cached)
?       github.com/weaveworks/eksctl/pkg/ctl/register   [no test files]
ok      github.com/weaveworks/eksctl/pkg/ctl/scale      (cached)
ok      github.com/weaveworks/eksctl/pkg/ctl/set        (cached)
ok      github.com/weaveworks/eksctl/pkg/ctl/unset      (cached)
ok      github.com/weaveworks/eksctl/pkg/ctl/update     (cached)
ok      github.com/weaveworks/eksctl/pkg/ctl/upgrade    (cached)
ok      github.com/weaveworks/eksctl/pkg/ctl/utils      (cached)
ok      github.com/weaveworks/eksctl/pkg/drain  (cached)
?       github.com/weaveworks/eksctl/pkg/drain/evictor  [no test files]
?       github.com/weaveworks/eksctl/pkg/drain/fakes    [no test files]
ok      github.com/weaveworks/eksctl/pkg/eks    (cached)
ok      github.com/weaveworks/eksctl/pkg/eks/auth       (cached) [no tests to run]
?       github.com/weaveworks/eksctl/pkg/eks/fakes      [no test files]
?       github.com/weaveworks/eksctl/pkg/eks/mocks      [no test files]
?       github.com/weaveworks/eksctl/pkg/eks/mocksv2    [no test files]
?       github.com/weaveworks/eksctl/pkg/eks/waiter     [no test files]
?       github.com/weaveworks/eksctl/pkg/elb    [no test files]
?       github.com/weaveworks/eksctl/pkg/executor       [no test files]
?       github.com/weaveworks/eksctl/pkg/executor/fakes [no test files]
ok      github.com/weaveworks/eksctl/pkg/fargate        (cached)
ok      github.com/weaveworks/eksctl/pkg/fargate/coredns        (cached)
ok      github.com/weaveworks/eksctl/pkg/flux   (cached)
?       github.com/weaveworks/eksctl/pkg/gitops [no test files]
ok      github.com/weaveworks/eksctl/pkg/iam    (cached)
ok      github.com/weaveworks/eksctl/pkg/iam/oidc       (cached)
ok      github.com/weaveworks/eksctl/pkg/info   (cached)
ok      github.com/weaveworks/eksctl/pkg/karpenter      (cached)
?       github.com/weaveworks/eksctl/pkg/karpenter/fakes        [no test files]
?       github.com/weaveworks/eksctl/pkg/karpenter/providers    [no test files]
?       github.com/weaveworks/eksctl/pkg/karpenter/providers/fakes      [no test files]
ok      github.com/weaveworks/eksctl/pkg/karpenter/providers/helm       (cached)
?       github.com/weaveworks/eksctl/pkg/kops   [no test files]
ok      github.com/weaveworks/eksctl/pkg/kubernetes     (cached)
ok      github.com/weaveworks/eksctl/pkg/managed        (cached)
ok      github.com/weaveworks/eksctl/pkg/nodebootstrap  (cached)
?       github.com/weaveworks/eksctl/pkg/nodebootstrap/assets   [no test files]
?       github.com/weaveworks/eksctl/pkg/nodebootstrap/fakes    [no test files]
?       github.com/weaveworks/eksctl/pkg/nodebootstrap/utils    [no test files]
ok      github.com/weaveworks/eksctl/pkg/outposts       (cached)
?       github.com/weaveworks/eksctl/pkg/outposts/fakes [no test files]
ok      github.com/weaveworks/eksctl/pkg/printers       (cached)
?       github.com/weaveworks/eksctl/pkg/ssh    [no test files]
ok      github.com/weaveworks/eksctl/pkg/ssh/client     (cached)
?       github.com/weaveworks/eksctl/pkg/testutils      [no test files]
?       github.com/weaveworks/eksctl/pkg/testutils/mockprovider [no test files]
ok      github.com/weaveworks/eksctl/pkg/utils  (cached)
ok      github.com/weaveworks/eksctl/pkg/utils/dir      (cached)
?       github.com/weaveworks/eksctl/pkg/utils/file     [no test files]
ok      github.com/weaveworks/eksctl/pkg/utils/instance (cached)
ok      github.com/weaveworks/eksctl/pkg/utils/ipnet    (cached)
ok      github.com/weaveworks/eksctl/pkg/utils/kubeconfig       0.832s
?       github.com/weaveworks/eksctl/pkg/utils/kubectl  [no test files]
ok      github.com/weaveworks/eksctl/pkg/utils/names    (cached)
?       github.com/weaveworks/eksctl/pkg/utils/nodes    [no test files]
ok      github.com/weaveworks/eksctl/pkg/utils/retry    (cached)
ok      github.com/weaveworks/eksctl/pkg/utils/strings  (cached)
ok      github.com/weaveworks/eksctl/pkg/utils/taints   (cached)
ok      github.com/weaveworks/eksctl/pkg/utils/tasks    (cached) [no tests to run]
?       github.com/weaveworks/eksctl/pkg/utils/waiters  [no test files]
ok      github.com/weaveworks/eksctl/pkg/version        (cached)
ok      github.com/weaveworks/eksctl/pkg/version/generate       (cached)
ok      github.com/weaveworks/eksctl/pkg/vpc    (cached)
?       github.com/weaveworks/eksctl/pkg/vpc/fakes      [no test files]
ok      github.com/weaveworks/eksctl/pkg/windows        (cached) [no tests to run]

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@Himangini Himangini added dependencies Pull requests that update a dependency file area/tech-debt Leftover improvements in code, testing and building and removed kind/improvement labels May 25, 2023
Copy link
Collaborator

@Himangini Himangini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@Himangini Himangini enabled auto-merge May 25, 2023 16:12
@Himangini Himangini merged commit 896eff9 into eksctl-io:main May 25, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tech-debt Leftover improvements in code, testing and building dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants