Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add profile flag support for get and delete access entry #7623

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Add profile flag support for get and delete access entry #7623

merged 1 commit into from
Feb 28, 2024

Conversation

yuxiang-zhang
Copy link
Member

Description

Fixes #7490

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 馃く

  • Backfilled missing tests for code in same general area 馃帀
  • Refactored something and made the world a better place 馃専

@yuxiang-zhang yuxiang-zhang marked this pull request as ready for review February 28, 2024 00:06
a-hilaly
a-hilaly approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憤

@yuxiang-zhang yuxiang-zhang merged commit 2f233fa into eksctl-io:main Feb 28, 2024
11 checks passed
@yuxiang-zhang yuxiang-zhang deleted the add-profile-to-get-ae branch February 28, 2024 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-hilaly a-hilaly a-hilaly approved these changes

Assignees
No one assigned
Labels
area/general-cli kind/improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] accessentry/accessentries can not operate with profile flag
2 participants
@yuxiang-zhang @a-hilaly