Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EKS-Addons support for pod identity associations #7807

Merged
merged 35 commits into from
Jun 3, 2024
Merged

EKS-Addons support for pod identity associations #7807

merged 35 commits into from
Jun 3, 2024

Conversation

TiberiuGC
Copy link
Collaborator

Description

Required IAM permissions for some EKS-Addons can now be configured via EKS Pod Identity Associations.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

TiberiuGC and others added 30 commits May 30, 2024 19:22
@TiberiuGC @cPu1
add new addon fields required for pod identity support
5782494
@TiberiuGC @cPu1
ammend create addon command to create roles for pod identity associat…
1d5b861 
…ions
@TiberiuGC @cPu1
ammend delete addon command to delete roles for pod identity associat…
cc94cf1 
…ions
@TiberiuGC @cPu1
small tweaks
a645a6e
@cPu1
Support updating podIdentityAssociations for addons
3c535ef
@cPu1
Show addon.podIdentityAssociations in get addon
4be08c8
@cPu1
Disallow updating podidentityassociations owned by addons
e079911
@cPu1
Show pod identities in get addons, use a pointer for addon.podIdent…
1e69cf0 
…ityAssociations
@cPu1
Update mocks
961bd52
@cPu1
Fix deleting the specified addon instead of all addons
07d83f1
@cPu1
Disallow deletion of addon pod identities in `delete podidentityassoc…
bfb0a8b 
…iation`
@cPu1
Show ownerARN in get podidentityassociations
77f841d
@cPu1
Fix create cluster when iam.podIdentityAssociations is unset
aeac061
@cPu1
Delete IAM resources when addon.podIdentityAssociations is []
b9eea35
@TiberiuGC @cPu1
take into account that not all EKS addons will support pod IDs at launch
1b0c2ca
@TiberiuGC @cPu1
add validations
7e32105
@cPu1
Migrate EKS addons to pod identity using the Addons API
cca112c
@TiberiuGC @cPu1
add unit tests and update generated files
8b9c4db
@cPu1
Migrate: ignore pod identity associations that already exist
5a58bc4 
Fixes eksctl-io#7753
@TiberiuGC @cPu1
add docs && tweak validation
0afd1ac
@cPu1
Delete old IRSA stack in update addon
3c4d4ee
@cPu1
Add integration test for addon.podIdentityAssociations
d5b6778
@TiberiuGC @cPu1
add integration tests for creating and deleting addons && bugfixes ar…
8a36b28 
…ound validations and error checking
@TiberiuGC @cPu1
update describe addon config command to return pod identity config
4bb1a7d
@TiberiuGC @cPu1
add auto-create-pod-identity-associations CLI flag
c63f625
@TiberiuGC @cPu1
update unit tests
80ecc7b
@TiberiuGC @cPu1
update list of minimum IAM permissions
befc6a9
@TiberiuGC @cPu1
tech debt - unskip tests from PI suite
d970920
@TiberiuGC @cPu1
fix addons integration test
55004c1
@cPu1
Allow updating addons with recommended IAM policies, disallow setting…
dda4a32 
… tags and wellKnownPolicies
@cPu1 cPu1 merged commit c7955ae into eksctl-io:main Jun 3, 2024
10 checks passed
This was referenced Jun 3, 2024
Merged
Merged
@orfeas-k orfeas-k mentioned this pull request Jun 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cPu1 cPu1 cPu1 approved these changes

Assignees
No one assigned
Labels
area/add-ons area/podidentity kind/feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TiberiuGC @cPu1