Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subnets availability validation should use AZs resolved by EC2::DescribeSubnets call #7816

Merged

Conversation

TiberiuGC
Copy link
Collaborator

Description

The validation in question was using the subnet keys found in the config file. However, subnet key doesn't necessarily represent the subnet's AZ, but can be a user given alias. Instead, the validation shall use the subnet AZ fetched from EC2::DescribeSubnets call.

Fixes #7785

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@TiberiuGC TiberiuGC force-pushed the bugfix/nodegroup-subnets-availability branch from e7f79cd to ac43182 Compare June 5, 2024 09:36
@TiberiuGC TiberiuGC force-pushed the bugfix/nodegroup-subnets-availability branch from ac43182 to 3248794 Compare June 5, 2024 09:37
@TiberiuGC TiberiuGC merged commit 4ee5579 into eksctl-io:main Jun 6, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants