Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added AWS X-Ray Support #805

Merged
merged 13 commits into from May 30, 2019
Merged

Added AWS X-Ray Support #805

merged 13 commits into from May 30, 2019

Commits on May 20, 2019

  1. Added AWS X-Ray Support 

    This change adds an `--xray-access` CLI flag, that when specified will
add an IAM policy to the node group IAM role. The IAM policy allows
outbound write access to AWS X-Ray.

The specific policy allows access to:
```
xray:PutTraceSegments
xray:PutTelemetryRecords
xray:GetSamplingRules
xray:GetSamplingTargets
xray:GetSamplingStatisticSummaries
```

This is useful, as AWS App Mesh (supported with `--appmesh-access` flag)
can optionally push metrics into AWS X-Ray. For an example of this see
the screenshots [here](https://github.com/PaulMaddox/aws-appmesh-helm).

Also see PaulMaddox/aws-appmesh-helm#1
    @PaulMaddox
    PaulMaddox committed May 20, 2019
    Copy the full SHA
    8890085 View commit details
    Browse the repository at this point in the history

  2. Updated humans.txt

    @PaulMaddox
    PaulMaddox committed May 20, 2019
    Copy the full SHA
    31a89c5 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into xray-access

    @PaulMaddox
    PaulMaddox committed May 20, 2019
    Copy the full SHA
    1118bb9 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2019

  1. Fix typo 'betwee' to 'between'

    @Tyil @PaulMaddox
    Tyil authored and PaulMaddox committed May 30, 2019
    Copy the full SHA
    d6e4111 View commit details
    Browse the repository at this point in the history

  2. Add myself to humans.txt, as per PR instructions

    @Tyil @PaulMaddox
    Tyil authored and PaulMaddox committed May 30, 2019
    Copy the full SHA
    e9aba28 View commit details
    Browse the repository at this point in the history

  3. Update issue templates 

    closes eksctl-io#434
    @martina-if @PaulMaddox
    martina-if authored and PaulMaddox committed May 30, 2019
    Copy the full SHA
    4799421 View commit details
    Browse the repository at this point in the history

  4. Include ec2:DescribeLaunchTemplateVersions policy for CA

    @martina-if @PaulMaddox
    martina-if authored and PaulMaddox committed May 30, 2019
    Copy the full SHA
    1cc92ee View commit details
    Browse the repository at this point in the history

  5. Fix setup instructions to include dep dependency 

    Was trying to do a build of the project to test out a currently open PR, and didn't have a preexisting Go setup on my machine.  Looks like you need dep installed to do the `make install-build-deps` step?  

Adding a bit to the documentation to save someone else time in the future
    @cpaika @PaulMaddox
    cpaika authored and PaulMaddox committed May 30, 2019
    Copy the full SHA
    a06e914 View commit details
    Browse the repository at this point in the history

  6. Fix search of ubuntu AMIs

    @martina-if @PaulMaddox
    martina-if authored and PaulMaddox committed May 30, 2019
    Copy the full SHA
    903de3c View commit details
    Browse the repository at this point in the history

  7. Describe bash3 completion workaround for macOS 

    Expands the help text for `eksctl completion bash --help` to include the
workaround for bash3 which is commonly found on macOSes.
    @rndstr @PaulMaddox
    rndstr authored and PaulMaddox committed May 30, 2019
    Copy the full SHA
    65f071a View commit details
    Browse the repository at this point in the history

  8. Updated humans.txt

    @PaulMaddox
    PaulMaddox committed May 30, 2019
    Copy the full SHA
    73099f2 View commit details
    Browse the repository at this point in the history

  9. Removed --xray-access CLI flag

    @PaulMaddox
    PaulMaddox committed May 30, 2019
    Copy the full SHA
    cf88d06 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'master' into xray-access

    @PaulMaddox
    PaulMaddox committed May 30, 2019
    Copy the full SHA
    7bf85c1 View commit details
    Browse the repository at this point in the history